Differential D8839

maven: Simplify tests with requests_mock_datadir fixture
ClosedPublic
Actions

Authored by anlambert on Nov 14 2022, 4:14 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBASE5778cfce008a: maven: Simplify tests with requests_mock_datadir fixture

Summary

Use mocked network requests to get jar and pom files instead of
reading them from the datadir directory.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

maven-simplify-tests

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32789
Build 51372: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 51371: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 14 2022, 4:14 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 14 2022, 4:14 PM

Build is green

Patch application report for D8839 (id=31853)

Rebasing onto bf2cb039d5...

Current branch diff-target is up to date.

Changes applied before test

commit 5778cfce008af543c566197f0c229637bceac287
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Nov 14 16:12:12 2022 +0100

    maven: Simplify tests with requests_mock_datadir fixture
    
    Use mocked network requests to get jar and pom files instead of
    reading them from the datadir directory.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/1021/ for more details.

Harbormaster completed remote builds in B32789: Diff 31853.Nov 14 2022, 4:17 PM

anlambert requested review of this revision.Nov 14 2022, 4:17 PM

anlambert added a child revision: D8840: maven: Add support for md5 checkums to check download integrity.Nov 14 2022, 4:27 PM

ardumont accepted this revision.Nov 14 2022, 5:44 PM

This revision is now accepted and ready to land.Nov 14 2022, 5:44 PM

Closed by commit rDLDBASE5778cfce008a: maven: Simplify tests with requests_mock_datadir fixture (authored by anlambert). · Explain WhyNov 15 2022, 11:48 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDBASE5778cfce008a: maven: Simplify tests with requests_mock_datadir fixture.

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

loader/

package/

maven/

tests/

data/

https_maven.org/

sprova4j-0.1.0-sources.jar

sprova4j-0.1.0-sources.jar.sha1

sprova4j-0.1.0.pom

sprova4j-0.1.1-sources.jar

sprova4j-0.1.1-sources.jar.sha1

sprova4j-0.1.1.pom

	https_repo1.maven.org/
	https_maven.org/

	maven2_al_aldi_sprova4j_0.1.0_sprova4j-0.1.0-sources.jar
	sprova4j-0.1.0-sources.jar

	maven2_al_aldi_sprova4j_0.1.0_sprova4j-0.1.0-sources.jar.sha1
	sprova4j-0.1.0-sources.jar.sha1

1 line

	maven2_al_aldi_sprova4j_0.1.0_sprova4j-0.1.0.pom
	sprova4j-0.1.0.pom

86 lines

	maven2_al_aldi_sprova4j_0.1.1_sprova4j-0.1.1-sources.jar
	sprova4j-0.1.1-sources.jar

	maven2_al_aldi_sprova4j_0.1.1_sprova4j-0.1.1-sources.jar.sha1
	sprova4j-0.1.1-sources.jar.sha1

1 line

	maven2_al_aldi_sprova4j_0.1.1_sprova4j-0.1.1.pom
	sprova4j-0.1.1.pom

86 lines

test_maven.py

101 lines

100%

Diff 31853

View Options

swh/loader/package/maven/tests/data/https_maven.org/sprova4j-0.1.0-sources.jar

View Options

swh/loader/package/maven/tests/data/https_maven.org/sprova4j-0.1.0-sources.jar.sha1

View Options

swh/loader/package/maven/tests/data/https_maven.org/sprova4j-0.1.0.pom

View Options

swh/loader/package/maven/tests/data/https_maven.org/sprova4j-0.1.1-sources.jar

View Options

swh/loader/package/maven/tests/data/https_maven.org/sprova4j-0.1.1-sources.jar.sha1

View Options

swh/loader/package/maven/tests/data/https_maven.org/sprova4j-0.1.1.pom

View Options

swh/loader/package/maven/tests/data/https_repo1.maven.org/maven2_al_aldi_sprova4j_0.1.0_sprova4j-0.1.0-sources.jar

View Options

swh/loader/package/maven/tests/data/https_repo1.maven.org/maven2_al_aldi_sprova4j_0.1.0_sprova4j-0.1.0-sources.jar.sha1

View Options

swh/loader/package/maven/tests/data/https_repo1.maven.org/maven2_al_aldi_sprova4j_0.1.0_sprova4j-0.1.0.pom

View Options

swh/loader/package/maven/tests/data/https_repo1.maven.org/maven2_al_aldi_sprova4j_0.1.1_sprova4j-0.1.1-sources.jar

View Options

swh/loader/package/maven/tests/data/https_repo1.maven.org/maven2_al_aldi_sprova4j_0.1.1_sprova4j-0.1.1-sources.jar.sha1

View Options

swh/loader/package/maven/tests/data/https_repo1.maven.org/maven2_al_aldi_sprova4j_0.1.1_sprova4j-0.1.1.pom

View Options

swh/loader/package/maven/tests/test_maven.py

maven: Simplify tests with requests_mock_datadir fixtureClosedPublicActions

Details

Diff Detail

Event Timeline

Patch application report for D8839 (id=31853)

Changes applied before test

Revision ContentsChangeset List

Diff 31853

swh/loader/package/maven/tests/data/https_maven.org/sprova4j-0.1.0-sources.jar

swh/loader/package/maven/tests/data/https_maven.org/sprova4j-0.1.0-sources.jar.sha1

swh/loader/package/maven/tests/data/https_maven.org/sprova4j-0.1.0.pom

swh/loader/package/maven/tests/data/https_maven.org/sprova4j-0.1.1-sources.jar

swh/loader/package/maven/tests/data/https_maven.org/sprova4j-0.1.1-sources.jar.sha1

swh/loader/package/maven/tests/data/https_maven.org/sprova4j-0.1.1.pom

swh/loader/package/maven/tests/data/https_repo1.maven.org/maven2_al_aldi_sprova4j_0.1.0_sprova4j-0.1.0-sources.jar

swh/loader/package/maven/tests/data/https_repo1.maven.org/maven2_al_aldi_sprova4j_0.1.0_sprova4j-0.1.0-sources.jar.sha1

swh/loader/package/maven/tests/data/https_repo1.maven.org/maven2_al_aldi_sprova4j_0.1.0_sprova4j-0.1.0.pom

swh/loader/package/maven/tests/data/https_repo1.maven.org/maven2_al_aldi_sprova4j_0.1.1_sprova4j-0.1.1-sources.jar

swh/loader/package/maven/tests/data/https_repo1.maven.org/maven2_al_aldi_sprova4j_0.1.1_sprova4j-0.1.1-sources.jar.sha1

swh/loader/package/maven/tests/data/https_repo1.maven.org/maven2_al_aldi_sprova4j_0.1.1_sprova4j-0.1.1.pom

swh/loader/package/maven/tests/test_maven.py

maven: Simplify tests with requests_mock_datadir fixture
ClosedPublic
Actions

Revision Contents
Changeset List