Page MenuHomeSoftware Heritage
Differential D8771

client: redact sensitive consumer settings before logging them
ClosedPublic
Actions

Authored by olasd on Oct 25 2022, 3:56 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDJNL1d879f1dd624: client: redact sensitive consumer settings before logging them
Summary

I don't like seeing passwords in my debug logs :-)

Diff Detail

Event Timeline

olasd created this revision.Oct 25 2022, 3:56 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptOct 25 2022, 3:56 PM
swh-public-ci added a comment.Oct 25 2022, 4:00 PM

Build is green

Patch application report for D8771 (id=31620)

Rebasing onto 7c83ee11ec...

Current branch diff-target is up to date.
Changes applied before test
commit 1d879f1dd6247b74d7e58dd0b4bd7b498ab506f0
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Aug 8 11:58:35 2022 +0200

    client: redact sensitive consumer settings before logging them

See https://jenkins.softwareheritage.org/job/DJNL/job/tests-on-diff/230/ for more details.

Harbormaster completed remote builds in B32573: Diff 31620.Oct 25 2022, 4:00 PM
olasd requested review of this revision.Oct 25 2022, 4:00 PM
vlorentz accepted this revision.Oct 25 2022, 4:06 PM
This revision is now accepted and ready to land.Oct 25 2022, 4:06 PM
Closed by commit rDJNL1d879f1dd624: client: redact sensitive consumer settings before logging them (authored by olasd). · Explain WhyOct 25 2022, 4:45 PM
This revision was automatically updated to reflect the committed changes.
olasd added a commit: rDJNL1d879f1dd624: client: redact sensitive consumer settings before logging them.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
journal/
9 lines73%
Loading...

Diff 31620

View Options

swh/journal/client.py

Loading...
About · Developer information · Legal