Page MenuHomeSoftware Heritage
Differential D965

Add more type checks to sanitize Mappings' input.
ClosedPublic
Actions

Authored by vlorentz on Jan 16 2019, 6:28 PM.

Details

Reviewers
douardda
Group Reviewers
Reviewers
Maniphest Tasks
T1475: Test more edge cases of metadata indexer mappings
Commits
rDCIDX3d414533eb5b: Add more type checks to sanitize input.

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
type-checks
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3651
Build 4749: tox-on-jenkinsJenkins
Build 4748: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jan 16 2019, 6:28 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 16 2019, 6:28 PM
vlorentz added a parent revision: D957: Factorize list merges in indexer mappings.Jan 16 2019, 6:28 PM
Harbormaster failed remote builds in B3570: Diff 3061!Jan 16 2019, 6:28 PM
swh-public-ci added a subscriber: swh-public-ci.Jan 16 2019, 6:28 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/228/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/228/console

vlorentz updated this revision to Diff 3074.Jan 17 2019, 11:54 AM
  • rebase
Harbormaster failed remote builds in B3583: Diff 3074!Jan 17 2019, 11:54 AM
swh-public-ci added a comment.Jan 17 2019, 11:54 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/232/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/232/console

vlorentz added a task: T1475: Test more edge cases of metadata indexer mappings.Jan 21 2019, 12:38 PM
vlorentz updated this revision to Diff 3125.Jan 22 2019, 10:55 AM
  • Fix merging with None.
vlorentz updated this revision to Diff 3126.Jan 22 2019, 10:55 AM
  • fix base commit
swh-public-ci added a comment.Jan 22 2019, 10:58 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/240/ for more details.

Harbormaster completed remote builds in B3650: Diff 3125.Jan 22 2019, 10:58 AM
Harbormaster failed remote builds in B3651: Diff 3126!
swh-public-ci added a comment.Jan 22 2019, 10:58 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/241/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/241/console

vlorentz updated this revision to Diff 3161.Jan 24 2019, 3:12 PM
  • Rebase
Harbormaster failed remote builds in B3687: Diff 3161!Jan 24 2019, 3:12 PM
swh-public-ci added a comment.Jan 24 2019, 3:12 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/266/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/266/console

vlorentz added a child revision: D998: Make metadata translation warnings reference revisions/content ids instead of dumping the content itself..Jan 24 2019, 4:34 PM
douardda accepted this revision.Jan 24 2019, 5:36 PM
douardda added a subscriber: douardda.

But I don't like the direction this takes...

This revision is now accepted and ready to land.Jan 24 2019, 5:36 PM
vlorentz added a comment.Jan 25 2019, 11:03 AM
In D965#21358, @douardda wrote:

But I don't like the direction this takes...

What do you mean?

vlorentz updated this revision to Diff 3230.Jan 29 2019, 10:15 AM
  • rebase
Closed by commit rDCIDX3d414533eb5b: Add more type checks to sanitize input. (authored by vlorentz). · Explain WhyJan 29 2019, 10:15 AM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B3774: Diff 3230!Jan 29 2019, 10:16 AM
swh-public-ci added a comment.Jan 29 2019, 10:16 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/284/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/284/console

Revision Contents
Changeset List

PathSize
swh/
indexer/
19 lines
tests/
37 lines

Diff 3126

View Options

swh/indexer/metadata_dictionary.py

Loading...
View Options

swh/indexer/tests/test_metadata.py

Loading...
About · Developer information · Legal