Differential D8596

package/utils: Fix download function documentation
ClosedPublic
Actions

Authored by anlambert on Oct 3 2022, 12:34 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBASEf6a3ed11b4f8: package/utils: Fix download function documentation

Summary

This function downloads a file and computes hashes on it, there is no
archive extraction step.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

download-doc-fixes

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32031
Build 50144: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 50143: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 3 2022, 12:34 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 3 2022, 12:34 PM

Build has FAILED

Patch application report for D8596 (id=31047)

Rebasing onto 5482a48ea1...

Current branch diff-target is up to date.

Changes applied before test

commit 26de978739b38c035f0602fc4b0f9948a927ffc6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 3 12:07:40 2022 +0200

    package/utils: Fix download function documentation
    
    This function downloads a file and computes hashes on it, there is no
    archive extraction step.

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/939/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/939/console

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 3 2022, 12:36 PM

Harbormaster failed remote builds in B32017: Diff 31047!

Build is green

Patch application report for D8596 (id=31047)

Rebasing onto dbf7f3dca0...

First, rewinding head to replay your work on top of it...
Applying: package/utils: Fix download function documentation

Changes applied before test

commit a7c2f824bdeb4c1eab76fe56c8494ba8cb674936
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 3 12:07:40 2022 +0200

    package/utils: Fix download function documentation
    
    This function downloads a file and computes hashes on it, there is no
    archive extraction step.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/942/ for more details.

Harbormaster completed remote builds in B32017: Diff 31047.Oct 3 2022, 2:46 PM

anlambert requested review of this revision.Oct 3 2022, 2:46 PM

oh yeah, correct, thx.
It's possible it used to so until it got extracted in the package loader instead.

This revision is now accepted and ready to land.Oct 3 2022, 2:49 PM

Rebase

rebase

Build is green

Patch application report for D8596 (id=31061)

Rebasing onto dbf7f3dca0...

Current branch diff-target is up to date.

Changes applied before test

commit 56df69f36a3309500448c855f347a1988cc4a4bf
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 3 12:07:40 2022 +0200

    package/utils: Fix download function documentation
    
    This function downloads a file and computes hashes on it, there is no
    archive extraction step.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/946/ for more details.

Harbormaster completed remote builds in B32031: Diff 31061.Oct 3 2022, 2:54 PM

Build is green

Patch application report for D8596 (id=31063)

Rebasing onto 39c33a66c2...

Current branch diff-target is up to date.

Changes applied before test

commit f6a3ed11b4f8e12628ef5f817ff2014dff654fac
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Oct 3 12:07:40 2022 +0200

    package/utils: Fix download function documentation
    
    This function downloads a file and computes hashes on it, there is no
    archive extraction step.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/947/ for more details.

Harbormaster completed remote builds in B32033: Diff 31063.Oct 3 2022, 2:57 PM

Closed by commit rDLDBASEf6a3ed11b4f8: package/utils: Fix download function documentation (authored by anlambert). · Explain WhyOct 3 2022, 3:14 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDBASEf6a3ed11b4f8: package/utils: Fix download function documentation.