This mirrors the behavior of the synchronous server.
In practice, this means the objstorage won't log ObjNotFoundError or
report them to Sentry.
Differential D8589 Authored by vlorentz on Sep 30 2022, 4:02 PM.
Details
Summary This mirrors the behavior of the synchronous server. In practice, this means the objstorage won't log ObjNotFoundError or
Diff Detail
Event TimelineHerald added a reviewer: Reviewers. · View Herald TranscriptSep 30 2022, 4:02 PM2022-09-30 16:02:34 (UTC+2) vlorentz retitled this revision from api/asynchronous: Do not log/report client exception to api/asynchronous: Do not log/report client exceptions.Sep 30 2022, 4:02 PM2022-09-30 16:02:54 (UTC+2) Comment Actions Build has FAILED Patch application report for D8589 (id=31008)Rebasing onto 5a898b2d56... Current branch diff-target is up to date. Changes applied before testcommit cf503bef04ba0c01edb24ebb57c6bf7a280ba596 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Fri Sep 30 16:01:16 2022 +0200 api/asynchronous: Do not log/report client exception This mirrors the behavior of the synchronous server. In practice, this means the objstorage won't log ObjNotFoundError or report them to Sentry. Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/474/ Harbormaster returned this revision to the author for changes because remote builds failed.Sep 30 2022, 4:04 PM2022-09-30 16:04:43 (UTC+2) Comment Actions Build is green Patch application report for D8589 (id=31041)Rebasing onto 5a898b2d56... Current branch diff-target is up to date. Changes applied before testcommit f848ebbbf6a7f9387a6f289825c6ed26e5e6e5bb Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Fri Sep 30 16:01:16 2022 +0200 api/asynchronous: Do not log/report client exception This mirrors the behavior of the synchronous server. In practice, this means the objstorage won't log ObjNotFoundError or report them to Sentry. See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/475/ for more details. Harbormaster completed remote builds in B32011: Diff 31041.Oct 3 2022, 12:04 PM2022-10-03 12:04:44 (UTC+2) This revision is now accepted and ready to land.Oct 3 2022, 12:34 PM2022-10-03 12:34:36 (UTC+2) Closed by commit rDCOREf848ebbbf6a7: api/asynchronous: Do not log/report client exception (authored by vlorentz). · Explain WhyOct 3 2022, 12:56 PM2022-10-03 12:56:00 (UTC+2) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 31041 swh/core/api/asynchronous.py
|
The same remark as https://forge.softwareheritage.org/D233#inline-1221 could be applied here.
If the storage api can deal with multiple sha1s, this is probably better to use it that way :)