Page MenuHomeSoftware Heritage

api/asynchronous: Do not log/report client exceptions
ClosedPublic

Authored by vlorentz on Sep 30 2022, 4:02 PM.

Details

Summary

This mirrors the behavior of the synchronous server.

In practice, this means the objstorage won't log ObjNotFoundError or
report them to Sentry.

Diff Detail

Event Timeline

vlorentz retitled this revision from api/asynchronous: Do not log/report client exception to api/asynchronous: Do not log/report client exceptions.Sep 30 2022, 4:02 PM

Build has FAILED

Patch application report for D8589 (id=31008)

Rebasing onto 5a898b2d56...

Current branch diff-target is up to date.
Changes applied before test
commit cf503bef04ba0c01edb24ebb57c6bf7a280ba596
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 30 16:01:16 2022 +0200

    api/asynchronous: Do not log/report client exception
    
    This mirrors the behavior of the synchronous server.
    
    In practice, this means the objstorage won't log ObjNotFoundError or
    report them to Sentry.

Link to build: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/474/
See console output for more information: https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/474/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 30 2022, 4:04 PM
Harbormaster failed remote builds in B31979: Diff 31008!

Build is green

Patch application report for D8589 (id=31041)

Rebasing onto 5a898b2d56...

Current branch diff-target is up to date.
Changes applied before test
commit f848ebbbf6a7f9387a6f289825c6ed26e5e6e5bb
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Sep 30 16:01:16 2022 +0200

    api/asynchronous: Do not log/report client exception
    
    This mirrors the behavior of the synchronous server.
    
    In practice, this means the objstorage won't log ObjNotFoundError or
    report them to Sentry.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/475/ for more details.

This revision is now accepted and ready to land.Oct 3 2022, 12:34 PM