Page MenuHomeSoftware Heritage
Differential D8576

conftest: Replace multiprocessing hack when pytest-cov >= 4 is installed
ClosedPublic
Actions

Authored by vlorentz on Sep 29 2022, 10:15 AM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSTO44616afe5109: conftest: Replace multiprocessing hack when pytest-cov >= 4 is installed
Summary

The hack crashes on >= 4 because 'pytest_cov.embed.multiprocessing_start'
is not in the hook list anymore.

https://pytest-cov.readthedocs.io/en/latest/changelog.html

Diff Detail

Repository
rDSTO Storage manager
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31908
Build 49943: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 49942: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
0 msJenkins > pytest::internal
Traceback (most recent call last): File "/var/lib/jenkins/workspace/DSTO/tests-on-diff/.tox/py3/lib/python3.7/site-packages/_pytest/main.py", line 268, in wrap_session session.exitstatus = doit(config, session) or 0
4 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_content
2 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_raw_extrinsic_metadata
556 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.algos.test_diff::test__get_rev
4 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.algos.test_diff.TestDiffRevisions::test_insert_delete
View Full Test Results (1 Failed · 1,622 Passed · 44 Skipped)

Event Timeline

vlorentz created this revision.Sep 29 2022, 10:15 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 29 2022, 10:15 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Sep 29 2022, 10:16 AM
Harbormaster failed remote builds in B31904: Diff 30932!
vlorentz updated this revision to Diff 30933.Sep 29 2022, 10:17 AM

reword commit

vlorentz edited the summary of this revision. (Show Details)Sep 29 2022, 10:17 AM
vlorentz published this revision for review.Sep 29 2022, 10:31 AM
swh-public-ci added a comment.Sep 29 2022, 10:32 AM

Build has FAILED

Patch application report for D8576 (id=30932)

Rebasing onto 87d3f0d7b4...

Current branch diff-target is up to date.
Changes applied before test
commit a04fea9e5d612ec24cb1099d35e0db4b5a94e50d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 29 10:15:36 2022 +0200

    conftest: Replace multiprocessing hack when pytest-cov >= 4 is installed
    
    The hack crashes on >= 4 because 'pytest_cov.embed.multiprocessing_start'
    does not exist anymore.
    
    https://pytest-cov.readthedocs.io/en/latest/changelog.html

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1669/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1669/console

swh-public-ci added a comment.Sep 29 2022, 10:33 AM

Build has FAILED

Patch application report for D8576 (id=30933)

Rebasing onto 87d3f0d7b4...

Current branch diff-target is up to date.
Changes applied before test
commit c3598dd4351cc9de4647278b2304d9c0f624be19
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 29 10:15:36 2022 +0200

    conftest: Replace multiprocessing hack when pytest-cov >= 4 is installed
    
    The hack crashes on >= 4 because 'pytest_cov.embed.multiprocessing_start'
    is not in the hook list anymore.
    
    https://pytest-cov.readthedocs.io/en/latest/changelog.html

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1670/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1670/console

Harbormaster failed remote builds in B31905: Diff 30933!Sep 29 2022, 10:33 AM
vlorentz updated this revision to Diff 30936.Sep 29 2022, 10:41 AM

fix CI?

swh-public-ci added a comment.Sep 29 2022, 10:57 AM

Build has FAILED

Patch application report for D8576 (id=30936)

Rebasing onto 87d3f0d7b4...

Current branch diff-target is up to date.
Changes applied before test
commit 89c5b72853581570e985bff52fedd43091751790
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 29 10:15:36 2022 +0200

    conftest: Replace multiprocessing hack when pytest-cov >= 4 is installed
    
    The hack crashes on >= 4 because 'pytest_cov.embed.multiprocessing_start'
    is not in the hook list anymore.
    
    https://pytest-cov.readthedocs.io/en/latest/changelog.html

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1672/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1672/console

Harbormaster failed remote builds in B31908: Diff 30936!Sep 29 2022, 10:57 AM
vlorentz updated this revision to Diff 30939.Sep 29 2022, 11:06 AM

what about this?

vlorentz mentioned this in D8574: postgresql: Remove merge join with origin_visit in origin_visit_get_latest.Sep 29 2022, 11:13 AM
vlorentz added a child revision: D8574: postgresql: Remove merge join with origin_visit in origin_visit_get_latest.
anlambert added a subscriber: anlambert.Sep 29 2022, 11:25 AM
anlambert added inline comments.
swh/storage/tests/conftest.py
40–42

distutils.version is deprecated, you could directly use pytest_cov.__version__ < "4.0.0" instead.

swh-public-ci added a comment.Sep 29 2022, 11:33 AM

Build was aborted

Patch application report for D8576 (id=30939)

Rebasing onto 87d3f0d7b4...

Current branch diff-target is up to date.
Changes applied before test
commit ebc70eaa6c8291ada5f07505e4a0f91366444a27
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 29 10:15:36 2022 +0200

    conftest: Replace multiprocessing hack when pytest-cov >= 4 is installed
    
    The hack crashes on >= 4 because 'pytest_cov.embed.multiprocessing_start'
    is not in the hook list anymore.
    
    https://pytest-cov.readthedocs.io/en/latest/changelog.html

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1673/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1673/console

Harbormaster failed remote builds in B31911: Diff 30939!Sep 29 2022, 11:33 AM
vlorentz updated this revision to Diff 30945.Sep 29 2022, 12:53 PM

use ad-hoc version parsing

vlorentz marked an inline comment as done.Sep 29 2022, 12:54 PM
swh-public-ci added a comment.Sep 29 2022, 1:09 PM

Build is green

Patch application report for D8576 (id=30945)

Rebasing onto 87d3f0d7b4...

Current branch diff-target is up to date.
Changes applied before test
commit 44616afe5109f495604b01cf72b412fbec8e94c0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 29 10:15:36 2022 +0200

    conftest: Replace multiprocessing hack when pytest-cov >= 4 is installed
    
    The hack crashes on >= 4 because 'pytest_cov.embed.multiprocessing_start'
    is not in the hook list anymore.
    
    https://pytest-cov.readthedocs.io/en/latest/changelog.html

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1674/ for more details.

Harbormaster completed remote builds in B31917: Diff 30945.Sep 29 2022, 1:09 PM
ardumont accepted this revision.Sep 29 2022, 4:44 PM
This revision is now accepted and ready to land.Sep 29 2022, 4:44 PM
Closed by commit rDSTO44616afe5109: conftest: Replace multiprocessing hack when pytest-cov >= 4 is installed (authored by vlorentz). · Explain WhySep 29 2022, 5:29 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSTO44616afe5109: conftest: Replace multiprocessing hack when pytest-cov >= 4 is installed.

Revision Contents
Changeset List

PathSize
4 lines
swh/
storage/
tests/
6 lines
1 line

Diff 30936

View Options

.coveragerc

Loading...
View Options

swh/storage/tests/conftest.py

Loading...
View Options

tox.ini

Loading...
About · Developer information · Legal