Paths

Table of Contentst

Differential D8575

forge.puppet.com
ClosedPublic
Actions

Authored by franckbret on Sep 29 2022, 10:06 AM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T4593: Create a puppet Loader

Commits

rDLDBASE6299c091ec85: Puppet: The puppet loader loads origins from https://forge.puppet.com

Summary

For each origin it takes advantage of 'artifacts' data send through
'extra_loader_arguments' from the Puppet lister, providing versions,
archive url, last_update, filename.
Author and description are extracted from intrinsic metadata.

Related T4580

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

puppet

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31906
Build 49939: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 49938: arc lint + arc unit

Event Timeline

franckbret created this revision.Sep 29 2022, 10:06 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 29 2022, 10:06 AM

Build has FAILED

Patch application report for D8575 (id=30931)

Rebasing onto 7375a83c2f...

Current branch diff-target is up to date.

Changes applied before test

commit a9a931b86c32a822efbf771ea612d9d244513722
Author: Franck Bret <franck.bret@octobus.net>
Date:   Thu Sep 29 09:54:55 2022 +0200

    Puppet: The puppet loader loads origins from https://forge.puppet.com
    
    For each origin it takes advantage of 'artifacts' data send through
    'extra_loader_arguments' from the Puppet lister, providing versions,
    archive url, last_update, filename.
    Author and description are extracted from intrinsic metadata.
    
    Related T4580

Link to build: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/909/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/909/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 29 2022, 10:09 AM

Harbormaster failed remote builds in B31903: Diff 30931!

Fix bad naming in test_tasks

Build is green

Patch application report for D8575 (id=30934)

Rebasing onto 7375a83c2f...

Current branch diff-target is up to date.

Changes applied before test

commit e40d737798c0355a4c6f02a95912eddb6714cf1f
Author: Franck Bret <franck.bret@octobus.net>
Date:   Thu Sep 29 09:54:55 2022 +0200

    Puppet: The puppet loader loads origins from https://forge.puppet.com
    
    For each origin it takes advantage of 'artifacts' data send through
    'extra_loader_arguments' from the Puppet lister, providing versions,
    archive url, last_update, filename.
    Author and description are extracted from intrinsic metadata.
    
    Related T4580

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/910/ for more details.

Harbormaster completed remote builds in B31906: Diff 30934.Sep 29 2022, 10:21 AM

franckbret requested review of this revision.Sep 29 2022, 10:21 AM

vlorentz added a subscriber: vlorentz.Sep 29 2022, 1:05 PM

vlorentz added inline comments.

swh/loader/package/puppet/loader.py
62	why isn't it a list of dicts like other loaders?
106	please check the filename ends with that string first

franckbret added subscribers: anlambert, ardumont.Sep 29 2022, 1:23 PM

franckbret added inline comments.

swh/loader/package/puppet/loader.py
62	Because some of you told me to do so on previous one (@ardumont and @anlambert on crates if I remember correctly. Practically with dict the loader does not have to built a dict to list versions, so its less conversion between data structure) Which form should be the canonical one? List of dict or dict of dict with version as key?

vlorentz added inline comments.Sep 29 2022, 1:31 PM

swh/loader/package/puppet/loader.py
62	anlambert and I had a discussion about this yesterday: D8553 I prefer to keep the list of dicts for now, until we define a proper alternative to `extra_loader_arguments` to pass these dicts.

franckbret added inline comments.Sep 29 2022, 1:37 PM

swh/loader/package/puppet/loader.py
62	okay, will rewrite the lister and loader then

franckbret added inline comments.Sep 29 2022, 1:49 PM

swh/loader/package/puppet/loader.py
62	@vlorentz and by the way as the lister as already been merged, I'll prefer to close and merge this one after I've fixed the check on tar.gz presence, and then create new patches for lister and loader if you don't mind?

Ensure filename ends with {version}.tar.gz before splitting filename to get a package name

Build is green

Patch application report for D8575 (id=30954)

Rebasing onto 2db1a754e3...

Current branch diff-target is up to date.

Changes applied before test

commit 6299c091ec8523ae7fbb8cfabe62f69799cedde2
Author: Franck Bret <franck.bret@octobus.net>
Date:   Thu Sep 29 09:54:55 2022 +0200

    Puppet: The puppet loader loads origins from https://forge.puppet.com
    
    For each origin it takes advantage of 'artifacts' data send through
    'extra_loader_arguments' from the Puppet lister, providing versions,
    archive url, last_update, filename.
    Author and description are extracted from intrinsic metadata.
    
    Related T4580

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/913/ for more details.

Harbormaster completed remote builds in B31926: Diff 30954.Sep 29 2022, 3:55 PM

franckbret marked an inline comment as done.Sep 29 2022, 3:59 PM

vlorentz accepted this revision.Sep 29 2022, 4:05 PM

This revision is now accepted and ready to land.Sep 29 2022, 4:05 PM

Closed by commit rDLDBASE6299c091ec85: Puppet: The puppet loader loads origins from https://forge.puppet.com (authored by franckbret). · Explain WhySep 29 2022, 4:07 PM

This revision was automatically updated to reflect the committed changes.

franckbret added a commit: rDLDBASE6299c091ec85: Puppet: The puppet loader loads origins from https://forge.puppet.com.

franckbret mentioned this in T4580: Puppet Loader.Sep 29 2022, 4:09 PM

bchauvet added a task: T4593: Create a puppet Loader.Sep 30 2022, 9:10 AM