Page MenuHomeSoftware Heritage
Differential D8463

cypress: Try to fix some flaky tests when executed in parallel
ClosedPublic
Actions

Authored by anlambert on Sep 13 2022, 2:40 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDWAPPS755755df44b2: cypress: Fix some flaky tests when executed in parallel
Summary

Some tests often end up flaky when executed in parallel.

This diff is a playground to try fixing those.

Diff Detail

Repository
rDWAPPS Web applications
Branch
cypress-flaky-fixes
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31551
Build 49352: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 49351: arc lint + arc unit

Event Timeline

anlambert created this revision.Sep 13 2022, 2:40 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 13 2022, 2:40 PM
swh-public-ci added a comment.Sep 13 2022, 2:51 PM

Build is green

Patch application report for D8463 (id=30491)

Rebasing onto 104f3b79bf...

Current branch diff-target is up to date.
Changes applied before test
commit 7f99f135d06ca5c589101f8967473df115b33a31
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 13 14:38:57 2022 +0200

    cypress: Try to fix some flaky tests when executed in parallel

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2052/ for more details.

Harbormaster completed remote builds in B31498: Diff 30491.Sep 13 2022, 2:51 PM
anlambert requested review of this revision.Sep 13 2022, 2:51 PM
swh-public-ci added a comment.Sep 13 2022, 3:10 PM

Build is green

Patch application report for D8463 (id=30491)

Rebasing onto 104f3b79bf...

Current branch diff-target is up to date.
Changes applied before test
commit 7f99f135d06ca5c589101f8967473df115b33a31
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 13 14:38:57 2022 +0200

    cypress: Try to fix some flaky tests when executed in parallel

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2055/ for more details.

swh-public-ci added a comment.Sep 13 2022, 3:10 PM

Build is green

Patch application report for D8463 (id=30491)

Rebasing onto 104f3b79bf...

Current branch diff-target is up to date.
Changes applied before test
commit 7f99f135d06ca5c589101f8967473df115b33a31
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 13 14:38:57 2022 +0200

    cypress: Try to fix some flaky tests when executed in parallel

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2054/ for more details.

anlambert updated this revision to Diff 30506.Sep 13 2022, 4:35 PM

It seems the issue comes from the use of some before hooks,
turning them to beforeEach ones seems to fix the issue.

swh-public-ci added a comment.Sep 13 2022, 4:53 PM

Build is green

Patch application report for D8463 (id=30506)

Rebasing onto a0b384e56f...

Current branch diff-target is up to date.
Changes applied before test
commit 7c6de78cbed95e245c9e9cb14cbbe1610043ecb0
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 13 14:38:57 2022 +0200

    cypress: Try to fix some flaky tests when executed in parallel

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2058/ for more details.

Harbormaster completed remote builds in B31513: Diff 30506.Sep 13 2022, 4:53 PM
swh-public-ci added a comment.Sep 14 2022, 10:58 AM

Build is green

Patch application report for D8463 (id=30506)

Rebasing onto 5b0ab27a8d...

First, rewinding head to replay your work on top of it...
Applying: cypress: Try to fix some flaky tests when executed in parallel
Changes applied before test
commit c108cc1d921d41d34b266cc3c18658633004128f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 13 14:38:57 2022 +0200

    cypress: Try to fix some flaky tests when executed in parallel

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2060/ for more details.

swh-public-ci added a comment.Sep 14 2022, 10:58 AM

Build is green

Patch application report for D8463 (id=30506)

Rebasing onto 5b0ab27a8d...

First, rewinding head to replay your work on top of it...
Applying: cypress: Try to fix some flaky tests when executed in parallel
Changes applied before test
commit 0513a061ec066af44440bf9ef7063de865a94486
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 13 14:38:57 2022 +0200

    cypress: Try to fix some flaky tests when executed in parallel

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2059/ for more details.

swh-public-ci added a comment.Sep 14 2022, 11:12 AM

Build is green

Patch application report for D8463 (id=30506)

Rebasing onto 5b0ab27a8d...

First, rewinding head to replay your work on top of it...
Applying: cypress: Try to fix some flaky tests when executed in parallel
Changes applied before test
commit acee5f75e6b0935e073720bf0d9fb466e554c1cb
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 13 14:38:57 2022 +0200

    cypress: Try to fix some flaky tests when executed in parallel

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2061/ for more details.

swh-public-ci added a comment.Sep 14 2022, 11:12 AM

Build is green

Patch application report for D8463 (id=30506)

Rebasing onto 5b0ab27a8d...

First, rewinding head to replay your work on top of it...
Applying: cypress: Try to fix some flaky tests when executed in parallel
Changes applied before test
commit acee5f75e6b0935e073720bf0d9fb466e554c1cb
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 13 14:38:57 2022 +0200

    cypress: Try to fix some flaky tests when executed in parallel

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2062/ for more details.

swh-public-ci added a comment.Sep 14 2022, 11:27 AM

Build is green

Patch application report for D8463 (id=30506)

Rebasing onto 5b0ab27a8d...

First, rewinding head to replay your work on top of it...
Applying: cypress: Try to fix some flaky tests when executed in parallel
Changes applied before test
commit 4e49d5203e9450142843b8b7a53098d51bd3784d
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 13 14:38:57 2022 +0200

    cypress: Try to fix some flaky tests when executed in parallel

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2063/ for more details.

swh-public-ci added a comment.Sep 14 2022, 11:27 AM

Build is green

Patch application report for D8463 (id=30506)

Rebasing onto 5b0ab27a8d...

First, rewinding head to replay your work on top of it...
Applying: cypress: Try to fix some flaky tests when executed in parallel
Changes applied before test
commit d5d062c0ba802784a20c5f69b9d911bb4a0cfe16
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 13 14:38:57 2022 +0200

    cypress: Try to fix some flaky tests when executed in parallel

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2064/ for more details.

anlambert updated this revision to Diff 30524.Sep 14 2022, 2:10 PM

Rebase and update commit message

swh-public-ci added a comment.Sep 14 2022, 2:18 PM

Build is green

Patch application report for D8463 (id=30524)

Rebasing onto 5b0ab27a8d...

Current branch diff-target is up to date.
Changes applied before test
commit f894060b15f6554f77b4d519128cd3eedf5f739f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 13 14:38:57 2022 +0200

    cypress: Fix some flaky tests when executed in parallel
    
    It seems there is an issue with the before hooks of cypress regarding
    their execution order when running tests in parallel.
    
    So turn some before hooks into beforEach ones to fix some flaky tests.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2066/ for more details.

Harbormaster completed remote builds in B31526: Diff 30524.Sep 14 2022, 2:18 PM
vlorentz accepted this revision.Sep 15 2022, 10:19 AM
This revision is now accepted and ready to land.Sep 15 2022, 10:19 AM
anlambert updated this revision to Diff 30551.Sep 15 2022, 11:02 AM

Rebase and fix typo in commit message

swh-public-ci added a comment.Sep 15 2022, 11:19 AM

Build is green

Patch application report for D8463 (id=30551)

Rebasing onto 58fae8e0ea...

Current branch diff-target is up to date.
Changes applied before test
commit 755755df44b2d413bccf19118885394b1889ca89
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Sep 13 14:38:57 2022 +0200

    cypress: Fix some flaky tests when executed in parallel
    
    It seems there is an issue with the before hooks of cypress regarding
    their execution order when running tests in parallel.
    
    So turn some before hooks into beforeEach ones to fix some flaky tests.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2068/ for more details.

Harbormaster completed remote builds in B31551: Diff 30551.Sep 15 2022, 11:19 AM
Closed by commit rDWAPPS755755df44b2: cypress: Fix some flaky tests when executed in parallel (authored by anlambert). · Explain WhySep 15 2022, 11:33 AM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDWAPPS755755df44b2: cypress: Fix some flaky tests when executed in parallel.

Revision Contents
Changeset List

Diff 30551

View Options

cypress/e2e/add-forge-now-request-dashboard.cy.js

Loading...
View Options

cypress/e2e/add-forge-now-requests-moderation.cy.js

Loading...
View Options

cypress/e2e/admin.cy.js

Loading...
About · Developer information · Legal