Differential D8428

npm: Do not generate URIs with spaces in them
ClosedPublic
Actions

Authored by vlorentz on Sep 8 2022, 5:19 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDCIDX6d7efad974dd: npm: Do not generate URIs with spaces in them

Summary

It makes rdflib complain, and is invalid anyway

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31409
Build 49133: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 49132: arc lint + arc unit

Event Timeline

vlorentz created this revision.Sep 8 2022, 5:19 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 8 2022, 5:19 PM

Build is green

Patch application report for D8428 (id=30388)

Could not rebase; Attempt merge onto b6385cec11...

Updating b6385ce..6d7efad
Fast-forward
 swh/indexer/metadata.py                | 2 +-
 swh/indexer/metadata_dictionary/npm.py | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)

Changes applied before test

commit 6d7efad974dd41cd01c9920627df5e7752b083ae
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 8 17:19:12 2022 +0200

    npm: Do not generate URIs with spaces in them
    
    It makes rdflib complain, and is invalid anyway

commit f4e08f950baa4d7f9a524e0a4815becb01c6649c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 8 17:18:29 2022 +0200

    Convert SWHID to str before passing to sentry_sdk.set_tag
    
    Sentry uses repr() by default, which does not look good in a UI

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/485/ for more details.

Harbormaster completed remote builds in B31409: Diff 30388.Sep 8 2022, 5:28 PM

vlorentz requested review of this revision.Sep 8 2022, 5:28 PM

anlambert accepted this revision.Sep 9 2022, 11:54 AM

This revision is now accepted and ready to land.Sep 9 2022, 11:54 AM

Closed by commit rDCIDX6d7efad974dd: npm: Do not generate URIs with spaces in them (authored by vlorentz). · Explain WhySep 12 2022, 10:54 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDX6d7efad974dd: npm: Do not generate URIs with spaces in them.