Page MenuHomeSoftware Heritage

npm: Do not generate URIs with spaces in them
ClosedPublic

Authored by vlorentz on Thu, Sep 8, 5:19 PM.

Details

Summary

It makes rdflib complain, and is invalid anyway

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8428 (id=30388)

Could not rebase; Attempt merge onto b6385cec11...

Updating b6385ce..6d7efad
Fast-forward
 swh/indexer/metadata.py                | 2 +-
 swh/indexer/metadata_dictionary/npm.py | 4 ++++
 2 files changed, 5 insertions(+), 1 deletion(-)
Changes applied before test
commit 6d7efad974dd41cd01c9920627df5e7752b083ae
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 8 17:19:12 2022 +0200

    npm: Do not generate URIs with spaces in them
    
    It makes rdflib complain, and is invalid anyway

commit f4e08f950baa4d7f9a524e0a4815becb01c6649c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 8 17:18:29 2022 +0200

    Convert SWHID to str before passing to sentry_sdk.set_tag
    
    Sentry uses repr() by default, which does not look good in a UI

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/485/ for more details.

This revision is now accepted and ready to land.Fri, Sep 9, 11:54 AM