Page MenuHomeSoftware Heritage
Differential D912

Rewrite the 'How to use' section as a 'Quick Start'
ClosedPublic
Actions

Authored by douardda on Jan 10 2019, 1:55 PM.

Details

Reviewers
vlorentz
Group Reviewers
Reviewers
Commits
rDENVe0795aa1d5e7: Rewrite the 'How to use' section as a 'Quick Start'
rCDFDe0795aa1d5e7: Rewrite the 'How to use' section as a 'Quick Start'
Summary

with a step-by-step approach.

Also add a section listing ports published on the host and a section on
tasks (SWH vs. Celery).

depends on D911

Diff Detail

Repository
rCDFD Dockerfiles for developers
Branch
loaders
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 3540
Build 4582: arc lint + arc unit

Event Timeline

douardda created this revision.Jan 10 2019, 1:55 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 10 2019, 1:55 PM
Harbormaster completed remote builds in B3354: Diff 2881.Jan 10 2019, 1:55 PM
ardumont added a subscriber: ardumont.EditedJan 10 2019, 3:05 PM

It's pretty good!

I do not see the benefits of altering the ports we already use for swh services though.

(Related to D911#19568).

That:

  • diverges from the ports used in production (5002 storage, 5003, objstorage, etc...)... Admitedly, i'm used to those ;)
  • introduces as you said in the readme a divergence in the way we actually run commands from within and out of the containers.

Also, the docker-compose ps output seems to be the old one (without the new ports remapping).

douardda updated this revision to Diff 3026.Jan 15 2019, 5:15 PM

rebased and adapted to nginx-based URIs

depends on D954

Harbormaster completed remote builds in B3528: Diff 3026.Jan 15 2019, 5:15 PM
douardda edited parent revisions, added: D954: Add an nginx service to group all http services on the same service endpoint; removed: D911: Try to rationalize a bit ports published on the host.Jan 15 2019, 5:16 PM
douardda updated this revision to Diff 3032.Jan 15 2019, 5:21 PM
douardda added a parent revision: D911: Try to rationalize a bit ports published on the host.

rebased

Harbormaster completed remote builds in B3535: Diff 3032.Jan 15 2019, 5:21 PM
douardda updated this revision to Diff 3036.Jan 15 2019, 5:30 PM

rebased

Harbormaster completed remote builds in B3540: Diff 3036.Jan 15 2019, 5:30 PM
vlorentz accepted this revision.Jan 15 2019, 6:23 PM
vlorentz added a subscriber: vlorentz.
vlorentz added inline comments.
README.md
229

components

245

executed

This revision is now accepted and ready to land.Jan 15 2019, 6:23 PM
douardda updated this revision to Diff 3087.Jan 17 2019, 4:17 PM

Rebase and fix a couple of typos

reported by vlorentz, thx!

Harbormaster completed remote builds in B3600: Diff 3087.Jan 17 2019, 4:17 PM
Closed by commit rCDFDe0795aa1d5e7: Rewrite the 'How to use' section as a 'Quick Start' (authored by douardda). · Explain WhyJan 17 2019, 4:17 PM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDENVe0795aa1d5e7: Rewrite the 'How to use' section as a 'Quick Start'.Nov 26 2019, 1:35 PM

Revision Contents
Changeset List

PathSize
199 lines

Diff 3036

View Options

README.md

Loading...
About · Developer information · Legal