Page MenuHomeSoftware Heritage
Differential D8376

cli: Pass all journal_client config keys to the JournalClient
ClosedPublic
Actions

Authored by vlorentz on Sep 1 2022, 1:58 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDCIDXb056d431fd5f: cli: Pass all journal_client config keys to the JournalClient

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31269
Build 48912: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 48911: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
633 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.tests.test_cli::test_cli_journal_client_without_brokers
cli_runner = <click.testing.CliRunner object at 0x7fa617ae9c50> swh_config = '/tmp/pytest-of-jenkins/pytest-0/test_cli_journal_client_withou0/indexer.yml' kafka_prefix = 'tllrzfbkui', kafka_server = '127.0.0.1:36733'
4 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.codemeta::swh.indexer.codemeta.make_absolute_uri
2 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.metadata_dictionary.github::swh.indexer.metadata_dictionary.github.GitHubMapping.normalize_license
8 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.metadata_dictionary.github::swh.indexer.metadata_dictionary.github.GitHubMapping.translate_forks_count
3 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.metadata_dictionary.github::swh.indexer.metadata_dictionary.github.GitHubMapping.translate_stargazers_count
View Full Test Results (1 Failed · 349 Passed · 11 Skipped)

Event Timeline

vlorentz created this revision.Sep 1 2022, 1:58 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 1 2022, 1:58 PM
vlorentz updated this revision to Diff 30230.Sep 1 2022, 2:00 PM

oops

ardumont published this revision for review.Sep 1 2022, 2:01 PM
ardumont added a subscriber: ardumont.

lgtm

ardumont accepted this revision.Sep 1 2022, 2:01 PM
This revision is now accepted and ready to land.Sep 1 2022, 2:01 PM
swh-public-ci added a comment.Sep 1 2022, 2:06 PM

Build is green

Patch application report for D8376 (id=30229)

Rebasing onto 2ebd7ee876...

Current branch diff-target is up to date.
Changes applied before test
commit fa53fd48e04e3cb26f7cc6fcfa0f3a72dfa30209
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 1 13:58:14 2022 +0200

    cli: Pass all journal_client config keys to the JournalClient

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/476/ for more details.

Harbormaster completed remote builds in B31268: Diff 30229.Sep 1 2022, 2:06 PM
swh-public-ci added a comment.Sep 1 2022, 2:08 PM

Build has FAILED

Patch application report for D8376 (id=30230)

Rebasing onto 2ebd7ee876...

Current branch diff-target is up to date.
Changes applied before test
commit 0b19f636dd95c858aead1603da9ae549cc8b4081
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 1 13:58:14 2022 +0200

    cli: Pass all journal_client config keys to the JournalClient

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/477/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/477/console

Harbormaster failed remote builds in B31269: Diff 30230!Sep 1 2022, 2:08 PM
vlorentz updated this revision to Diff 30231.Sep 1 2022, 2:11 PM

fix incorrect when no brokers

This revision was landed with ongoing or failed builds.Sep 1 2022, 2:13 PM
Closed by commit rDCIDXb056d431fd5f: cli: Pass all journal_client config keys to the JournalClient (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDCIDXb056d431fd5f: cli: Pass all journal_client config keys to the JournalClient.
swh-public-ci added a comment.Sep 1 2022, 2:19 PM

Build is green

Patch application report for D8376 (id=30231)

Rebasing onto 2ebd7ee876...

Current branch diff-target is up to date.
Changes applied before test
commit b056d431fd5fa5d18ae6e38693e343caacda0c6f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 1 13:58:14 2022 +0200

    cli: Pass all journal_client config keys to the JournalClient

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/478/ for more details.

Harbormaster completed remote builds in B31270: Diff 30231.Sep 1 2022, 2:19 PM

Revision Contents
Changeset List

PathSize
swh/
indexer/
23 lines

Diff 30230

View Options

swh/indexer/cli.py

Loading...
About · Developer information · Legal