Differential D8376

cli: Pass all journal_client config keys to the JournalClient
ClosedPublic
Actions

Authored by vlorentz on Sep 1 2022, 1:58 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCIDXb056d431fd5f: cli: Pass all journal_client config keys to the JournalClient

Diff Detail

Repository

rDCIDX Metadata indexer

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Sep 1 2022, 1:58 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 1 2022, 1:58 PM

oops

lgtm

ardumont accepted this revision.Sep 1 2022, 2:01 PM

This revision is now accepted and ready to land.Sep 1 2022, 2:01 PM

Build is green

Patch application report for D8376 (id=30229)

Rebasing onto 2ebd7ee876...

Current branch diff-target is up to date.

Changes applied before test

commit fa53fd48e04e3cb26f7cc6fcfa0f3a72dfa30209
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 1 13:58:14 2022 +0200

    cli: Pass all journal_client config keys to the JournalClient

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/476/ for more details.

Harbormaster completed remote builds in B31268: Diff 30229.Sep 1 2022, 2:06 PM

Build has FAILED

Patch application report for D8376 (id=30230)

Rebasing onto 2ebd7ee876...

Current branch diff-target is up to date.

Changes applied before test

commit 0b19f636dd95c858aead1603da9ae549cc8b4081
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 1 13:58:14 2022 +0200

    cli: Pass all journal_client config keys to the JournalClient

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/477/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/477/console

Harbormaster failed remote builds in B31269: Diff 30230!Sep 1 2022, 2:08 PM

fix incorrect when no brokers

This revision was landed with ongoing or failed builds.Sep 1 2022, 2:13 PM

Closed by commit rDCIDXb056d431fd5f: cli: Pass all journal_client config keys to the JournalClient (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDXb056d431fd5f: cli: Pass all journal_client config keys to the JournalClient.

Build is green

Patch application report for D8376 (id=30231)

Rebasing onto 2ebd7ee876...

Current branch diff-target is up to date.

Changes applied before test

commit b056d431fd5fa5d18ae6e38693e343caacda0c6f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 1 13:58:14 2022 +0200

    cli: Pass all journal_client config keys to the JournalClient

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/478/ for more details.

Harbormaster completed remote builds in B31270: Diff 30231.Sep 1 2022, 2:19 PM