Page MenuHomeSoftware Heritage

vault: Move feature into its own django application
ClosedPublic

Authored by anlambert on Sep 1 2022, 11:45 AM.

Details

Summary

It was previously included in the browse application but it makes
sense to isolate it in its own application in order to easily
deactivate it if needed.

Related to T4398

Diff Detail

Repository
rDWAPPS Web applications
Branch
django-apps-refactoring-vault
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31257
Build 48893: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 48892: arc lint + arc unit

Unit TestsFailed

TimeTest
0 msJenkins > "before all" hook for "should report an error when vault service is experiencing issues"::Tests / Cypress tests / Run cypress tests / Vault Cooking User Interface Tests "before all" hook for "should report an error when vault service is experiencing issues"
TypeError: this.Urls.api_1_vault_cook_flat is not a function Because this error occurred during a `before all` hook we are skipping the remaining tests in the current suite: `Vault Cooking User Interfac...`
250,117 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_origin::Tests / Python tests / test_api_lookup_origin_visits_by_id
api_client = <rest_framework.test.APIClient object at 0x7f9130e92208> subtest = <function subtest.<locals>.inner at 0x7f9132c75b70>
200 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.browse.views.test_directory::Tests / Python tests / test_root_directory_view
client = <django.test.client.Client object at 0x7f90eb477080> archive_data = <swh.web.tests.conftest._ArchiveData object at 0x7f90eb477860> directory = '30195ac221e023104cae5649450d516a9b94e3db'
181 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.browse.views.test_directory::Tests / Python tests / test_sub_directory_view
client = <django.test.client.Client object at 0x7f90f1994f98> archive_data = <swh.web.tests.conftest._ArchiveData object at 0x7f90f1994fd0> directory_with_subdirs = '73425ab9abe2e4ac731e02ad96202c5bc96b4583'
1,608 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.browse.views.test_directory::Tests / Python tests / test_sub_directory_view_origin_context
client = <django.test.client.Client object at 0x7f90ec5ca048> archive_data = <swh.web.tests.conftest._ArchiveData object at 0x7f90ec5ca278> empty_directory = '4b825dc642cb6eb9a060e54bf8d69288fbee4904'
View Full Test Results (12 Failed · 1,011 Passed · 2 Skipped)

Event Timeline

Build has FAILED

Patch application report for D8375 (id=30219)

Rebasing onto 86f2e94eb3...

Current branch diff-target is up to date.
Changes applied before test
commit 4fc161f93e9f18984475b2a4af49c46752f0c91f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 1 11:42:36 2022 +0200

    vault: Move feature into its own django application
    
    It was previously included in the browse application but it makes
    sense to isolate it in its own application in order to easily
    deactivate it if needed.
    
    Related to T4398

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2027/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2027/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 1 2022, 12:00 PM
Harbormaster failed remote builds in B31257: Diff 30219!

Build is green

Patch application report for D8375 (id=30220)

Rebasing onto 86f2e94eb3...

Current branch diff-target is up to date.
Changes applied before test
commit 1c36c4f969c3d7b98b6d21766a75f0f4c6c0efe6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 1 11:42:36 2022 +0200

    vault: Move feature into its own django application
    
    It was previously included in the browse application but it makes
    sense to isolate it in its own application in order to easily
    deactivate it if needed.
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2028/ for more details.

This revision is now accepted and ready to land.Sep 1 2022, 12:27 PM