Differential D949

Better error message on content retrieval error + don't write translated_metadata=None to the idx storage.
ClosedPublic
Actions

Authored by vlorentz on Jan 15 2019, 2:27 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Maniphest Tasks

T1385: Monitor output of metadata indexers

Commits

rDCIDXebf9a35c45ca: If there was an error translating metadata, return no result.
rDCIDX2a87f6db8ab0: Better error message on content retrieval error.

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

error-content-retrieval

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 3511
Build 4548: tox-on-jenkins	Jenkins
Build 4547: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jan 15 2019, 2:27 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 15 2019, 2:27 PM

Harbormaster completed remote builds in B3483: Diff 2987.Jan 15 2019, 2:30 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/204/ for more details.

ardumont requested changes to this revision.Jan 15 2019, 2:32 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/indexer/metadata.py
79	%s", hashutil.hash_to_hex(id))

This revision now requires changes to proceed.Jan 15 2019, 2:32 PM

ardumont added inline comments.Jan 15 2019, 2:32 PM

swh/indexer/metadata.py
79	i meant: %s" % hashutil.hash_to_hex(id))

vlorentz marked an inline comment as done.Jan 15 2019, 3:14 PM

vlorentz added inline comments.

swh/indexer/metadata.py
79	Either way works

even better error message

If there was an error translating metadata, return no result.

vlorentz retitled this revision from Better error message on content retrieval error. to Better error message on content retrieval error + don't write translated_metadata=None to the idx storage..Jan 15 2019, 3:40 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/210/ for more details.

Harbormaster completed remote builds in B3509: Diff 3007.Jan 15 2019, 3:41 PM

Fix test.

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/211/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/211/console

Harbormaster failed remote builds in B3510: Diff 3008!Jan 15 2019, 3:43 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/212/ for more details.

Harbormaster completed remote builds in B3511: Diff 3009.Jan 15 2019, 3:46 PM

vlorentz added a task: T1385: Monitor output of metadata indexers.Jan 15 2019, 3:57 PM

ardumont accepted this revision.Jan 15 2019, 4:55 PM

This revision is now accepted and ready to land.Jan 15 2019, 4:55 PM

Squash

Closed by commit rDCIDX2a87f6db8ab0: Better error message on content retrieval error. (authored by vlorentz). · Explain WhyJan 15 2019, 5:00 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B3517: Diff 3016!Jan 15 2019, 5:01 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/214/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/214/console

Revision Contents
Changeset List

Path

Size

swh/

indexer/

5 lines

tests/

test_metadata.py

3 lines

Diff 3009

swh/indexer/metadata.py

Loading...

swh/indexer/tests/test_metadata.py

Loading...