Page MenuHomeSoftware Heritage

Better error message on content retrieval error + don't write translated_metadata=None to the idx storage.
ClosedPublic

Authored by vlorentz on Jan 15 2019, 2:27 PM.

Diff Detail

Repository
rDCIDX Object indexer
Branch
error-content-retrieval
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3510
Build 4546: tox-on-jenkinsJenkins
Build 4545: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jan 15 2019, 2:27 PM
ardumont requested changes to this revision.Jan 15 2019, 2:32 PM
ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/indexer/metadata.py
80
%s", hashutil.hash_to_hex(id))
This revision now requires changes to proceed.Jan 15 2019, 2:32 PM
ardumont added inline comments.Jan 15 2019, 2:32 PM
swh/indexer/metadata.py
80

i meant:

%s" % hashutil.hash_to_hex(id))
vlorentz marked an inline comment as done.Jan 15 2019, 3:14 PM
vlorentz added inline comments.
swh/indexer/metadata.py
80

Either way works

vlorentz updated this revision to Diff 3007.Jan 15 2019, 3:37 PM
  • even better error message
vlorentz updated this revision to Diff 3008.Jan 15 2019, 3:39 PM
  • If there was an error translating metadata, return no result.
vlorentz retitled this revision from Better error message on content retrieval error. to Better error message on content retrieval error + don't write translated_metadata=None to the idx storage..Jan 15 2019, 3:40 PM
vlorentz updated this revision to Diff 3009.Jan 15 2019, 3:42 PM
  • Fix test.
ardumont accepted this revision.Jan 15 2019, 4:55 PM
This revision is now accepted and ready to land.Jan 15 2019, 4:55 PM
vlorentz updated this revision to Diff 3016.Jan 15 2019, 5:00 PM
  • Squash
This revision was automatically updated to reflect the committed changes.