Differential D8332

Raise StorageArgumentException on ProgramLimitExceeded
ClosedPublic
Actions

Authored by vlorentz on Aug 29 2022, 2:25 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO57e5431cec36: Raise StorageArgumentException on ProgramLimitExceeded

Summary

So it is no logged on the server side, and so clients do not retry

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31132
Build 48701: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 48700: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 29 2022, 2:25 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 29 2022, 2:25 PM

Build is green

Patch application report for D8332 (id=30087)

Rebasing onto b5836bab0d...

Current branch diff-target is up to date.

Changes applied before test

commit 57e5431cec36b7f1e7ef82d7b9fd42820613bec9
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Aug 29 14:24:56 2022 +0200

    Raise StorageArgumentException on ProgramLimitExceeded
    
    So it is no logged on the server side, and so clients do not retry

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1658/ for more details.

Harbormaster completed remote builds in B31132: Diff 30087.Aug 29 2022, 2:41 PM

vlorentz requested review of this revision.Aug 29 2022, 2:41 PM

ardumont accepted this revision.Aug 29 2022, 5:34 PM

This revision is now accepted and ready to land.Aug 29 2022, 5:34 PM

Closed by commit rDSTO57e5431cec36: Raise StorageArgumentException on ProgramLimitExceeded (authored by vlorentz). · Explain WhyAug 30 2022, 12:08 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTO57e5431cec36: Raise StorageArgumentException on ProgramLimitExceeded.