Page MenuHomeSoftware Heritage

Split batch_duration_seconds metric in two
ClosedPublic

Authored by vlorentz on Aug 18 2022, 3:12 PM.

Details

Summary

It will probably be useful to know what part of the check
takes the most time.

Event Timeline

Build is green

Patch application report for D8253 (id=29810)

Could not rebase; Attempt merge onto c6f711ecbf...

Updating c6f711e..f1a61b1
Fast-forward
 swh/scrubber/storage_checker.py | 28 ++++++++++++++--------------
 1 file changed, 14 insertions(+), 14 deletions(-)
Changes applied before test
commit f1a61b1f501a5c3e342972c66688b08400dacea6
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 18 15:12:37 2022 +0200

    Split batch_duration_seconds metric in two
    
    It will probably be useful to know what part of the check
    takes the most time.

commit 0cc86b0e45f015429406112b16e8b2e5196512ba
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 18 15:07:19 2022 +0200

    Deduplicate statsd calls
    
    This will allow adding more tags easily in future commits

See https://jenkins.softwareheritage.org/job/DSCRUB/job/tests-on-diff/54/ for more details.

Maybe use the same metric with an operation="check_hashes"/"check_references" tag?

This revision is now accepted and ready to land.Aug 18 2022, 4:38 PM

Build is green

Patch application report for D8253 (id=29821)

Could not rebase; Attempt merge onto c6f711ecbf...

Updating c6f711e..aaae867
Fast-forward
 swh/scrubber/storage_checker.py | 30 +++++++++++++++++-------------
 1 file changed, 17 insertions(+), 13 deletions(-)
Changes applied before test
commit aaae867e8d297d8f1aee26e4326209d69c3b392f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 18 15:12:37 2022 +0200

    Split batch_duration_seconds metric in two
    
    It will probably be useful to know what part of the check
    takes the most time.

commit 0cc86b0e45f015429406112b16e8b2e5196512ba
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 18 15:07:19 2022 +0200

    Deduplicate statsd calls
    
    This will allow adding more tags easily in future commits

See https://jenkins.softwareheritage.org/job/DSCRUB/job/tests-on-diff/59/ for more details.