Differential D8188

NpmMapping: Validate author URLs before passing them to PyLD
ClosedPublic
Actions

Authored by vlorentz on Aug 4 2022, 4:20 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCIDX98153fb7edba: NpmMapping: Validate author URLs before passing them to PyLD

Summary

Invalid URLs are a common source of crashes

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

pyld-crash

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 30625
Build 47884: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 47883: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 4 2022, 4:20 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 4 2022, 4:20 PM

Build is green

Patch application report for D8188 (id=29553)

Could not rebase; Attempt merge onto f31f1f5b34...

Updating f31f1f5..6a60789
Fast-forward
 requirements-test.txt                  |  5 +++++
 requirements.txt                       |  6 +++---
 swh/indexer/metadata_dictionary/npm.py | 21 ++++++++++++++++++---
 3 files changed, 26 insertions(+), 6 deletions(-)

Changes applied before test

commit 6a60789d8e518c0118925deeb52e41f41ed941b7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 4 16:19:56 2022 +0200

    NpmMapping: Validating author URLs before passing them to PyLD
    
    Invalid URLs are a common source of crashes

commit 53e3c5ee8f20b92fc495a8e73dce25397abd5c6c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 3 17:38:05 2022 +0200

    requirements-test.txt: Blacklist Flask 2.2.0 for tests

commit 134412093ad8147e907745062167732dbab0eaa4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 3 17:36:33 2022 +0200

    requirements.txt: Relax dependency on frozendict

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/399/ for more details.

Harbormaster completed remote builds in B30619: Diff 29553.Aug 4 2022, 4:28 PM

vlorentz requested review of this revision.Aug 4 2022, 4:28 PM

rebase

Build is green

Patch application report for D8188 (id=29559)

Rebasing onto 134412093a...

Current branch diff-target is up to date.

Changes applied before test

commit 682c45367a240f4b2794bf26fd3ab8690ee8f567
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 4 16:19:56 2022 +0200

    NpmMapping: Validating author URLs before passing them to PyLD
    
    Invalid URLs are a common source of crashes

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/400/ for more details.

Harbormaster completed remote builds in B30625: Diff 29559.Aug 4 2022, 5:24 PM

ardumont accepted this revision.Aug 4 2022, 5:26 PM

ardumont added a subscriber: ardumont.

ardumont added inline comments.

swh/indexer/metadata_dictionary/npm.py
144

This revision is now accepted and ready to land.Aug 4 2022, 5:26 PM

fix typos

vlorentz marked an inline comment as done.Aug 4 2022, 5:27 PM

vlorentz retitled this revision from NpmMapping: Validating author URLs before passing them to PyLD to NpmMapping: Validate author URLs before passing them to PyLD.

Build is green

Patch application report for D8188 (id=29561)

Rebasing onto 134412093a...

Current branch diff-target is up to date.

Changes applied before test

commit 98153fb7edba149c850c0d0671ed93ba475a3c5a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 4 16:19:56 2022 +0200

    NpmMapping: Validate author URLs before passing them to PyLD
    
    Invalid URLs are a common source of crashes

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/401/ for more details.

Harbormaster completed remote builds in B30627: Diff 29561.Aug 4 2022, 5:36 PM

Closed by commit rDCIDX98153fb7edba: NpmMapping: Validate author URLs before passing them to PyLD (authored by vlorentz). · Explain WhyAug 5 2022, 10:17 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDX98153fb7edba: NpmMapping: Validate author URLs before passing them to PyLD.