Page MenuHomeSoftware Heritage

NpmMapping: Validate author URLs before passing them to PyLD
ClosedPublic

Authored by vlorentz on Thu, Aug 4, 4:20 PM.

Details

Summary

Invalid URLs are a common source of crashes

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Build is green

Patch application report for D8188 (id=29553)

Could not rebase; Attempt merge onto f31f1f5b34...

Updating f31f1f5..6a60789
Fast-forward
 requirements-test.txt                  |  5 +++++
 requirements.txt                       |  6 +++---
 swh/indexer/metadata_dictionary/npm.py | 21 ++++++++++++++++++---
 3 files changed, 26 insertions(+), 6 deletions(-)
Changes applied before test
commit 6a60789d8e518c0118925deeb52e41f41ed941b7
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 4 16:19:56 2022 +0200

    NpmMapping: Validating author URLs before passing them to PyLD
    
    Invalid URLs are a common source of crashes

commit 53e3c5ee8f20b92fc495a8e73dce25397abd5c6c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 3 17:38:05 2022 +0200

    requirements-test.txt: Blacklist Flask 2.2.0 for tests

commit 134412093ad8147e907745062167732dbab0eaa4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 3 17:36:33 2022 +0200

    requirements.txt: Relax dependency on frozendict

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/399/ for more details.

Build is green

Patch application report for D8188 (id=29559)

Rebasing onto 134412093a...

Current branch diff-target is up to date.
Changes applied before test
commit 682c45367a240f4b2794bf26fd3ab8690ee8f567
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 4 16:19:56 2022 +0200

    NpmMapping: Validating author URLs before passing them to PyLD
    
    Invalid URLs are a common source of crashes

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/400/ for more details.

ardumont added a subscriber: ardumont.
ardumont added inline comments.
swh/indexer/metadata_dictionary/npm.py
143
This revision is now accepted and ready to land.Thu, Aug 4, 5:26 PM
vlorentz retitled this revision from NpmMapping: Validating author URLs before passing them to PyLD to NpmMapping: Validate author URLs before passing them to PyLD.

Build is green

Patch application report for D8188 (id=29561)

Rebasing onto 134412093a...

Current branch diff-target is up to date.
Changes applied before test
commit 98153fb7edba149c850c0d0671ed93ba475a3c5a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Aug 4 16:19:56 2022 +0200

    NpmMapping: Validate author URLs before passing them to PyLD
    
    Invalid URLs are a common source of crashes

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/401/ for more details.