Page MenuHomeSoftware Heritage
Differential D8179

Drop ctags indexer references and hidden api using it
ClosedPublic
Actions

Authored by ardumont on Aug 4 2022, 10:24 AM.

Details

Reviewers
anlambert
vlorentz
Group Reviewers
Reviewers
Maniphest Tasks
T4273: Rewrite indexers as journal clients when relevant
Commits
rDWAPPS3e5d552a3283: Drop ctags indexer references and hidden api using it
Summary

The ctags indexer has been stopped a long time ago and recently got dropped from the
indexer base code. As the api exposing this in the webapp is hidden, we can safely
remove them.

This also fixes build [1].

Related to T4273

[1] https://jenkins.softwareheritage.org/view/swh%20master%20(draft)/job/DWAPPS/job/tests/3265/console

Diff Detail

Unit TestsFailed
View All

TimeTest
172 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.api.views.test_content::Tests / Python tests / test_api_content_symbol_not_found
api_client = <rest_framework.test.APIClient object at 0x7f25136e12b0> def test_api_content_symbol_not_found(api_client):
22,719 msJenkins > should select correct visit type if possible when clicking on "Save again" button::Tests / Cypress tests / Run cypress tests / Origin Save Tests should select correct visit type if possible when clicking on "Save again" button
CypressError: Timed out retrying after 20050ms: `cy.click()` failed because this element is detached from the DOM. `<button class="btn btn-default btn-sm swh-save-origin-again" type="button" onclick="swh.save.fillSaveRequestFormAndScroll('git', 'https://gitlab.inria.fr/solverstack/maphys/maphys/');">...</button>`
554 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.add_forge_now.test_migration::Tests / Python tests / test_add_forge_now_allow_no_comment
414 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.add_forge_now.test_migration::Tests / Python tests / test_add_forge_now_initial_migration
400 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.add_forge_now.test_migration::Tests / Python tests / test_add_forge_now_store_submitter_forward_username
View Full Test Results (2 Failed · 1,010 Passed · 2 Skipped)

Event Timeline

ardumont created this revision.Aug 4 2022, 10:24 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptAug 4 2022, 10:24 AM
ardumont mentioned this in D8178: add-forge-now: Display forge url as link in moderation view.Aug 4 2022, 10:25 AM
ardumont added a child revision: D8178: add-forge-now: Display forge url as link in moderation view.Aug 4 2022, 10:27 AM
swh-public-ci added a comment.Aug 4 2022, 10:41 AM

Build has FAILED

Patch application report for D8179 (id=29529)

Rebasing onto 6f223dcb66...

Current branch diff-target is up to date.
Changes applied before test
commit 89954bdce3389091d4bf4feeb188e241fa44fcd4
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 4 10:22:56 2022 +0200

    tests/data: Drop ctags indexer reference
    
    They no longer exist.
    
    This fixes build [1]
    
    Related to T4273
    
    [1] https://jenkins.softwareheritage.org/view/swh%20master%20(draft)/job/DWAPPS/job/tests/3265/console

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1949/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1949/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 4 2022, 10:41 AM
Harbormaster failed remote builds in B30596: Diff 29529!
ardumont updated this revision to Diff 29532.Aug 4 2022, 11:14 AM

Fix furher ctags related code

ardumont retitled this revision from tests/data: Drop ctags indexer reference to tests/data: Drop ctags indexer references and hidden api using it.Aug 4 2022, 11:15 AM
ardumont edited the summary of this revision. (Show Details)
ardumont added a reviewer: anlambert.
swh-public-ci added a comment.Aug 4 2022, 11:15 AM

Build has FAILED

Patch application report for D8179 (id=29532)

Rebasing onto 6f223dcb66...

Current branch diff-target is up to date.
Changes applied before test
commit 2490004a2cb032f229e75b6043c755e2a5edd3dc
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 4 10:22:56 2022 +0200

    tests/data: Drop ctags indexer references and hidden api using it
    
    The ctags indexer has been stopped a long time ago and recently got dropped from the
    indexer base code. As the api exposing this in the webapp is hidden, we can safely
    remove them.
    
    This also fixes build [1].
    
    Related to T4273
    
    [1] https://jenkins.softwareheritage.org/view/swh%20master%20(draft)/job/DWAPPS/job/tests/3265/console

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1951/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1951/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 4 2022, 11:15 AM
Harbormaster failed remote builds in B30599: Diff 29532!
ardumont updated this revision to Diff 29533.Aug 4 2022, 11:18 AM

Fix flake8 stuff

swh-public-ci added a comment.Aug 4 2022, 11:34 AM

Build has FAILED

Patch application report for D8179 (id=29533)

Rebasing onto 6f223dcb66...

Current branch diff-target is up to date.
Changes applied before test
commit 578b3bd05098340fcf1e780bb41f5dbb5fa8c5a9
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 4 10:22:56 2022 +0200

    tests/data: Drop ctags indexer references and hidden api using it
    
    The ctags indexer has been stopped a long time ago and recently got dropped from the
    indexer base code. As the api exposing this in the webapp is hidden, we can safely
    remove them.
    
    This also fixes build [1].
    
    Related to T4273
    
    [1] https://jenkins.softwareheritage.org/view/swh%20master%20(draft)/job/DWAPPS/job/tests/3265/console

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1952/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1952/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 4 2022, 11:34 AM
Harbormaster failed remote builds in B30600: Diff 29533!
ardumont updated this revision to Diff 29534.Aug 4 2022, 11:43 AM

Fix missed test to remove

ardumont retitled this revision from tests/data: Drop ctags indexer references and hidden api using it to Drop ctags indexer references and hidden api using it.Aug 4 2022, 11:48 AM
swh-public-ci added a comment.Aug 4 2022, 12:00 PM

Build is green

Patch application report for D8179 (id=29534)

Rebasing onto 6f223dcb66...

Current branch diff-target is up to date.
Changes applied before test
commit 3e5d552a328353fafa505904c664486c4ad2b05c
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Thu Aug 4 10:22:56 2022 +0200

    Drop ctags indexer references and hidden api using it
    
    The ctags indexer has been stopped a long time ago and recently got dropped from the
    indexer base code. As the api exposing this in the webapp is hidden, we can safely
    remove them.
    
    This also fixes build [1].
    
    Related to T4273
    
    [1] https://jenkins.softwareheritage.org/view/swh%20master%20(draft)/job/DWAPPS/job/tests/3265/console

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1953/ for more details.

Harbormaster completed remote builds in B30601: Diff 29534.Aug 4 2022, 12:00 PM
ardumont requested review of this revision.Aug 4 2022, 12:00 PM
vlorentz accepted this revision.Aug 4 2022, 12:31 PM
This revision is now accepted and ready to land.Aug 4 2022, 12:31 PM
Closed by commit rDWAPPS3e5d552a3283: Drop ctags indexer references and hidden api using it (authored by ardumont). · Explain WhyAug 4 2022, 12:33 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDWAPPS3e5d552a3283: Drop ctags indexer references and hidden api using it.

Revision Contents
Changeset List

PathSize
swh/
web/
api/
views/
64 lines
common/
48 lines
tests/
api/
views/
80 lines
common/
61 lines
1 line
46 lines
21 lines

Diff 29533

View Options

swh/web/api/views/content.py

Loading...
View Options

swh/web/common/archive.py

Loading...
View Options

swh/web/tests/api/views/test_content.py

Loading...
View Options

swh/web/tests/common/test_archive.py

Loading...
View Options

swh/web/tests/common/test_utils.py

Loading...
View Options

swh/web/tests/conftest.py

Loading...
View Options

swh/web/tests/data.py

Loading...
About · Developer information · Legal