Hash dicts are now prefered by swh-objstorage, in order to support
individual hash collisions.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Maniphest Tasks
- T4402: Pass dict of hashes instead of single sha1 to objstorage.get()
- Commits
- rDVAUee678042f9bb: Call objstorage.get() with a HashDict instead of single hash
Depends on D8122
Diff Detail
Diff Detail
- Repository
- rDVAU Software Heritage Vault
- Branch
- objid
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 30454 Build 47610: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 47609: arc lint + arc unit
Event Timeline
Comment Actions
Build has FAILED
Patch application report for D8137 (id=29380)
Could not rebase; Attempt merge onto c07d934aef...
Updating c07d934..251cf7a Fast-forward swh/vault/cache.py | 15 ++++++++------- swh/vault/cookers/git_bare.py | 2 +- swh/vault/tests/test_cache.py | 5 ++--- swh/vault/to_disk.py | 2 +- 4 files changed, 12 insertions(+), 12 deletions(-)
Changes applied before test
commit 251cf7a91b2c366b7e255aa2e918e1cdc887f842
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Jul 19 15:06:06 2022 +0200
Call objstorage.get() with a HashDict instead of single hash
Hash dicts are now prefered by swh-objstorage, in order to support
individual hash collisions.
commit ceb26750ad9ddaeb8d725f18051f6f34038f3672
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Jul 19 14:55:07 2022 +0200
Fix mypy error
This is not a runtime issue, because when the supplied mode is DentryPerms.symlink,
the target is only used passed to os.symlink, which does allow str too.Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/243/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/243/console
Comment Actions
Build is green
Patch application report for D8137 (id=29380)
Rebasing onto ca71a59eda...
First, rewinding head to replay your work on top of it... Applying: Call objstorage.get() with a HashDict instead of single hash
Changes applied before test
commit a20a549d45561bb6ae3bcde25fd710e4265d5cb2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Jul 19 15:06:06 2022 +0200
Call objstorage.get() with a HashDict instead of single hash
Hash dicts are now prefered by swh-objstorage, in order to support
individual hash collisions.See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/251/ for more details.
Comment Actions
Build is green
Patch application report for D8137 (id=30129)
Rebasing onto ca71a59eda...
Current branch diff-target is up to date.
Changes applied before test
commit ee678042f9bb38bf3616c250a95dbbc8077d0dca
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Jul 19 15:06:06 2022 +0200
Call objstorage.get() with a HashDict instead of single hash
Hash dicts are now prefered by swh-objstorage, in order to support
individual hash collisions.See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/252/ for more details.