Differential D8109

Add support for non-ASCII filenames in api_content_raw (option 2: copy FileResponse.set_headers)
AbandonedPublic
Actions

Authored by vlorentz on Jul 11 2022, 4:33 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

Restricted Maniphest Task

Summary

without either RFC5987/6266-encoding of the filename or RFC2231-encoding
of the header, gunicorn crashes when trying to decode the header as ASCII.

Resolves T4388

This is an alternative implementation of D8108.

Diff Detail

Repository

rDWAPPS Web applications

Branch

content-filename-nonascii2

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 30367
Build 47474: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 47473: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jul 11 2022, 4:33 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 11 2022, 4:33 PM

vlorentz mentioned this in D8108: Add support for non-ASCII filenames in api_content_raw (option 1: use FileResponse).Jul 11 2022, 4:33 PM

Build is green

Patch application report for D8109 (id=29281)

Rebasing onto 27663adfa4...

First, rewinding head to replay your work on top of it...
Applying: Add support for non-ASCII filenames in api_content_raw

Changes applied before test

commit 2d505f87e41ff3b12702bdffba86d964bac463fc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Jul 11 16:28:40 2022 +0200

    Add support for non-ASCII filenames in api_content_raw
    
    without either RFC5987/6266-encoding of the filename or RFC2231-encoding
    of the header, gunicorn crashes when trying to decode the header as ASCII.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1915/ for more details.

Harbormaster completed remote builds in B30367: Diff 29281.Jul 11 2022, 4:57 PM

vlorentz requested review of this revision.Jul 11 2022, 4:57 PM