Page MenuHomeSoftware Heritage
Differential D901

Generate the gitlab's instance name from the api_baseurl by default
ClosedPublic
Actions

Authored by douardda on Jan 9 2019, 5:11 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDLSfb9265bb0315: Generate the gitlab's instance name from the api_baseurl by default
Summary

using the host of the given url.

This allows to create a lister task by simply specify the API base url
and prevent 'inconsistent by default' behavior, eg. with:

swh-scheduler task add swh-lister-gitlab-full \
    api_baseurl=https://0xacab.org/api/v4

the created task does not use 'gitlab' as instance name (but '0xacab.org'
here).

It's still possible to explicitely specify the instance name if needed.

depends on D893

Diff Detail

Repository
rDLS Listers
Branch
tasks-forever
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 3384
Build 4361: tox-on-jenkinsJenkins
Build 4360: arc lint + arc unit

Event Timeline

douardda created this revision.Jan 9 2019, 5:11 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJan 9 2019, 5:11 PM
Harbormaster failed remote builds in B3317: Diff 2857!Jan 9 2019, 5:11 PM
swh-public-ci added a subscriber: swh-public-ci.Jan 9 2019, 5:12 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/44/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/44/console

douardda mentioned this in D902: Add loader workers services.Jan 9 2019, 5:29 PM
ardumont added a subscriber: ardumont.Jan 10 2019, 1:15 AM

I like the idea.

Thanks.

It's still possible to explicitely specify the instance name if needed.

Is it still needed though?
Maybe we could simply drop the instance name now and always derive it from the url as you introduced here.

ardumont added a comment.Jan 10 2019, 8:53 AM
This comment was removed by ardumont.
ardumont accepted this revision.Jan 10 2019, 9:46 AM

forgot to accept.

Is it still needed though?
Maybe we could simply drop the instance name now and always derive it from the url as you introduced here.

In any case, that's not a blocker ;)

This revision is now accepted and ready to land.Jan 10 2019, 9:46 AM
douardda updated this revision to Diff 2902.Jan 10 2019, 4:00 PM

fix tests

Closed by commit rDLSfb9265bb0315: Generate the gitlab's instance name from the api_baseurl by default (authored by douardda). · Explain WhyJan 10 2019, 4:01 PM
This revision was automatically updated to reflect the committed changes.
swh-public-ci added a comment.Jan 10 2019, 4:01 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tox/45/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tox/45/console

Harbormaster failed remote builds in B3384: Diff 2902!Jan 10 2019, 4:01 PM

Revision Contents
Changeset List

PathSize
swh/
lister/
gitlab/
5 lines
2 lines
tests/
54 lines

Diff 2902

View Options

swh/lister/gitlab/lister.py

Loading...
View Options

swh/lister/gitlab/tasks.py

Loading...
View Options

swh/lister/gitlab/tests/test_tasks.py

Loading...
About · Developer information · Legal