Page MenuHomeSoftware Heritage

Generate the gitlab's instance name from the api_baseurl by default
ClosedPublic

Authored by douardda on Jan 9 2019, 5:11 PM.

Details

Summary

using the host of the given url.

This allows to create a lister task by simply specify the API base url
and prevent 'inconsistent by default' behavior, eg. with:

swh-scheduler task add swh-lister-gitlab-full \
    api_baseurl=https://0xacab.org/api/v4

the created task does not use 'gitlab' as instance name (but '0xacab.org'
here).

It's still possible to explicitely specify the instance name if needed.

depends on D893

Diff Detail

Repository
rDLS Listers
Branch
tasks-forever
Lint
Lint Skipped
Unit
Unit Tests Skipped
Build Status
Buildable 3384
Build 4361: tox-on-jenkinsJenkins
Build 4360: arc lint + arc unit

Event Timeline

I like the idea.

Thanks.

It's still possible to explicitely specify the instance name if needed.

Is it still needed though?
Maybe we could simply drop the instance name now and always derive it from the url as you introduced here.

This comment was removed by ardumont.

forgot to accept.

Is it still needed though?
Maybe we could simply drop the instance name now and always derive it from the url as you introduced here.

In any case, that's not a blocker ;)

This revision is now accepted and ready to land.Jan 10 2019, 9:46 AM
This revision was automatically updated to reflect the committed changes.