Add forge now: prepare fields for inbound email processing
ClosedPublic
Actions

Authored by olasd on May 10 2022, 1:19 PM.

Details

Reviewers

Group Reviewers

Commits

rDWAPPS5d37baf27ec0: Add forge now: add view to retrieve RequestHistory.message_source
rDWAPPS633b4319c4ad: Add forge now: prepare fields for inbound email processing

Summary

add raw message field to request history table, and relevant view to access it
add email as choice for the request history actor roles, when the message can't be matched to a known actor

Depends on D7798.

Test Plan

added a couple of python tests for this. Testing the new link in
cypress will happen when we hook up email processing

Diff Detail

Repository

rDWAPPS Web applications

Branch

detached-head

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29253
Build 45738: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 45737: arc lint + arc unit

Event Timeline

olasd created this revision.May 10 2022, 1:19 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 10 2022, 1:19 PM

what about "message_source" instead of "raw_message"? IMO it's clearer

Build is green

Patch application report for D7799 (id=28172)

Could not rebase; Attempt merge onto 84fd757cf8...

Updating 84fd757c..3f4da941
Fast-forward
 .../bundles/add_forge/add-request-history-item.ejs |  3 +
 assets/src/bundles/add_forge/request-dashboard.js  |  2 +-
 .../add-forge-now-request-dashboard.spec.js        |  7 +-
 .../migrations/0005_prepare_inbound_email.py       | 30 ++++++++
 swh/web/add_forge_now/models.py                    | 26 +++++++
 swh/web/add_forge_now/views.py                     | 32 +++++++++
 swh/web/api/views/add_forge_now.py                 | 20 +++++-
 swh/web/config.py                                  |  1 +
 swh/web/tests/add_forge_now/test_models.py         | 14 +++-
 swh/web/tests/api/views/test_add_forge_now.py      | 83 +++++++++++++++++++++-
 10 files changed, 209 insertions(+), 9 deletions(-)
 create mode 100644 swh/web/add_forge_now/migrations/0005_prepare_inbound_email.py

Changes applied before test

commit 3f4da941a759444ade8860c060769629cd12a829
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri May 6 18:36:48 2022 +0200

    Add forge now: add view to retrieve RequestHistory.raw_message
    
    To access this view, one can follow the link inside RequestHistory API
    responses.

commit 3af94b02c2ee2bd92be18650d4ae80c61465083f
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Apr 1 17:08:47 2022 +0200

    Add forge now: prepare fields for inbound email processing
    
    - add raw message field to request history table
    - add email as choice for the request history actor roles, when the
      message can't be matched to a known actor

commit 9b80cf37065930c6cee71a5558a349e48a12e2da
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue May 10 12:35:51 2022 +0200

    Add Forge Now: add a forge_domain property for use in templates
    
    This lets us generate more meaningful email subjects for request
    tracking, and will be useful for raw message filename generation too.

commit 833b171c69325d863fb06d0ec603ebd0be9f8b6c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Apr 1 10:38:38 2022 +0200

    Add forge now: add inbound email address to model

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1816/ for more details.

Harbormaster completed remote builds in B29237: Diff 28172.May 10 2022, 1:41 PM

olasd requested review of this revision.May 10 2022, 1:41 PM

In D7799#202967, @vlorentz wrote:

what about "message_source" instead of "raw_message"? IMO it's clearer

Yeah, that's a good idea.

I'll bundle that up in the next rebase. Any other suggestions?

no, that's all

This revision is now accepted and ready to land.May 10 2022, 1:44 PM

Rebase; rename all raw_message fields to message_source

olasd added a child revision: D7326: Hook up processing of inbound emails for add_forge_now.May 10 2022, 3:54 PM

Build is green

Patch application report for D7799 (id=28191)

Rebasing onto 3fc9c9276c...

Current branch diff-target is up to date.

Changes applied before test

commit 5d37baf27ec046ed7c54ce92ebc13f8cb753d51d
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri May 6 18:36:48 2022 +0200

    Add forge now: add view to retrieve RequestHistory.message_source
    
    To access this view, one can follow the link inside RequestHistory API
    responses.

commit 633b4319c4ad0e3dbefe13552d7af86c449b50f7
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Apr 1 17:08:47 2022 +0200

    Add forge now: prepare fields for inbound email processing
    
    - add message source field to request history table
    - add email as choice for the request history actor roles, when the
      message can't be matched to a known actor

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1821/ for more details.

Harbormaster completed remote builds in B29253: Diff 28191.May 10 2022, 4:14 PM

Closed by commit rDWAPPS633b4319c4ad: Add forge now: prepare fields for inbound email processing (authored by olasd). · Explain WhyMay 10 2022, 4:15 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDWAPPS633b4319c4ad: Add forge now: prepare fields for inbound email processing.

olasd added a commit: rDWAPPS5d37baf27ec0: Add forge now: add view to retrieve RequestHistory.message_source.

olasd mentioned this in D7326: Hook up processing of inbound emails for add_forge_now.May 10 2022, 4:15 PM