Differential D7798

Add Forge Now: add a forge_domain property for use in templates
ClosedPublic
Actions

Authored by olasd on May 10 2022, 1:12 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPS9b80cf370659: Add Forge Now: add a forge_domain property for use in templates

Summary

This lets us generate more meaningful email subjects for request
tracking, and will be useful for raw message filename generation too.

Depends on D7753

Test Plan

updated the pytest and cypress tests

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.May 10 2022, 1:12 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 10 2022, 1:12 PM

olasd added a child revision: D7799: Add forge now: prepare fields for inbound email processing.May 10 2022, 1:19 PM

Build is green

Patch application report for D7798 (id=28171)

Could not rebase; Attempt merge onto 84fd757cf8...

Updating 84fd757c..9b80cf37
Fast-forward
 assets/src/bundles/add_forge/request-dashboard.js  |  2 +-
 .../add-forge-now-request-dashboard.spec.js        |  7 ++++---
 swh/web/add_forge_now/models.py                    | 24 ++++++++++++++++++++++
 swh/web/api/views/add_forge_now.py                 |  2 ++
 swh/web/config.py                                  |  1 +
 swh/web/tests/add_forge_now/test_models.py         | 14 ++++++++++++-
 swh/web/tests/api/views/test_add_forge_now.py      | 23 ++++++++++++++++++++-
 7 files changed, 67 insertions(+), 6 deletions(-)

Changes applied before test

commit 9b80cf37065930c6cee71a5558a349e48a12e2da
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue May 10 12:35:51 2022 +0200

    Add Forge Now: add a forge_domain property for use in templates
    
    This lets us generate more meaningful email subjects for request
    tracking, and will be useful for raw message filename generation too.

commit 833b171c69325d863fb06d0ec603ebd0be9f8b6c
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Apr 1 10:38:38 2022 +0200

    Add forge now: add inbound email address to model

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1815/ for more details.

Harbormaster completed remote builds in B29236: Diff 28171.May 10 2022, 1:35 PM

olasd requested review of this revision.May 10 2022, 1:35 PM

vlorentz added a subscriber: vlorentz.May 10 2022, 1:36 PM

vlorentz added inline comments.