Page MenuHomeSoftware Heritage
Differential D877

Fix ctags tests.
ClosedPublic
Actions

Authored by vlorentz on Dec 21 2018, 11:20 AM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDCIDX6b9328e87178: Fix ctags tests.
Summary

Depends on D876

Diff Detail

Repository
rDCIDX Metadata indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 21 2018, 11:20 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 21 2018, 11:20 AM
swh-public-ci added a subscriber: swh-public-ci.Dec 21 2018, 11:23 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/166/ for more details.

Harbormaster completed remote builds in B3234: Diff 2783.Dec 21 2018, 11:23 AM
vlorentz updated this revision to Diff 2784.Dec 21 2018, 12:07 PM
  • typo
swh-public-ci added a comment.Dec 21 2018, 12:10 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/167/ for more details.

Harbormaster completed remote builds in B3235: Diff 2784.Dec 21 2018, 12:10 PM
olasd added a subscriber: olasd.Dec 21 2018, 5:28 PM

If you're using your mocks for all tests, couldn't you just set them up in the setUp method?

vlorentz updated this revision to Diff 2805.Jan 7 2019, 11:25 AM
  • Set-up mocks in setUp instead of using decorator on all methods.
Harbormaster failed remote builds in B3253: Diff 2805!Jan 7 2019, 11:25 AM
swh-public-ci added a comment.Jan 7 2019, 11:25 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/176/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/176/console

vlorentz updated this revision to Diff 2806.Jan 7 2019, 11:41 AM
  • Rebase
swh-public-ci added a comment.Jan 7 2019, 11:44 AM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/177/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/177/console

Harbormaster failed remote builds in B3254: Diff 2806!Jan 7 2019, 11:44 AM
vlorentz updated this revision to Diff 2808.Jan 7 2019, 11:51 AM
  • fix typo
swh-public-ci added a comment.Jan 7 2019, 11:54 AM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/178/ for more details.

Harbormaster completed remote builds in B3256: Diff 2808.Jan 7 2019, 11:54 AM
olasd accepted this revision.Jan 7 2019, 2:29 PM
This revision is now accepted and ready to land.Jan 7 2019, 2:29 PM
vlorentz updated this revision to Diff 2811.Jan 7 2019, 2:38 PM
  • Rebase
Closed by commit rDCIDX6b9328e87178: Fix ctags tests. (authored by vlorentz). · Explain WhyJan 7 2019, 2:38 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster failed remote builds in B3260: Diff 2811!Jan 7 2019, 2:39 PM
swh-public-ci added a comment.Jan 7 2019, 2:39 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/179/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tox/179/console

Revision Contents
Changeset List

PathSize
swh/
indexer/
tests/
44 lines

Diff 2812

View Options

swh/indexer/tests/test_ctags.py

Loading...
About · Developer information · Legal