Page MenuHomeSoftware Heritage

Fix ctags tests.
ClosedPublic

Authored by vlorentz on Dec 21 2018, 11:20 AM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDCIDX6b9328e87178: Fix ctags tests.
Summary

Depends on D876

Diff Detail

Repository
rDCIDX Object indexer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 21 2018, 11:20 AM
olasd added a subscriber: olasd.Dec 21 2018, 5:28 PM

If you're using your mocks for all tests, couldn't you just set them up in the setUp method?

vlorentz updated this revision to Diff 2805.Jan 7 2019, 11:25 AM
  • Set-up mocks in setUp instead of using decorator on all methods.
vlorentz updated this revision to Diff 2806.Jan 7 2019, 11:41 AM
  • Rebase
vlorentz updated this revision to Diff 2808.Jan 7 2019, 11:51 AM
  • fix typo
olasd accepted this revision.Jan 7 2019, 2:29 PM
This revision is now accepted and ready to land.Jan 7 2019, 2:29 PM
vlorentz updated this revision to Diff 2811.Jan 7 2019, 2:38 PM
  • Rebase
This revision was automatically updated to reflect the committed changes.