Using unnamed arguments is unsafe with celery tasks and parsing visit_date
is still required in case that parameter is used.
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDLDSVN1633257f11b5: tasks: Remove unnamed arguments use and restore visit_date parsing
Diff Detail
Diff Detail
- Repository
- rDLDSVN Subversion (SVN) loader
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 28889 Build 45156: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 45155: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D7698 (id=27828)
Rebasing onto b4bca94f05...
Current branch diff-target is up to date.
Changes applied before test
commit 1633257f11b56f8837c947308a8db167f3e63e91
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date: Wed Apr 27 15:16:36 2022 +0200
tasks: Remove unnamed arguments use and restore visit_date parsing
Using unnamed arguments is unsafe with celery tasks and parsing visit_date
is still required in case that parameter is used.See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/326/ for more details.
Comment Actions
lgtm
I think it was an old usage (when we still wanted to load as in we ingested it in the past)...
It'd be great to deprecate that use and finally drop it if it's actually unused (i think it's not).