Differential D7698

tasks: Remove unnamed arguments use and restore visit_date parsing
ClosedPublic
Actions

Authored by anlambert on Apr 27 2022, 3:18 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDSVN1633257f11b5: tasks: Remove unnamed arguments use and restore visit_date parsing

Summary

Using unnamed arguments is unsafe with celery tasks and parsing visit_date
is still required in case that parameter is used.

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.Apr 27 2022, 3:18 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 27 2022, 3:18 PM

Build is green

Patch application report for D7698 (id=27828)

Rebasing onto b4bca94f05...

Current branch diff-target is up to date.

Changes applied before test

commit 1633257f11b56f8837c947308a8db167f3e63e91
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Apr 27 15:16:36 2022 +0200

    tasks: Remove unnamed arguments use and restore visit_date parsing
    
    Using unnamed arguments is unsafe with celery tasks and parsing visit_date
    is still required in case that parameter is used.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/326/ for more details.

Harbormaster completed remote builds in B28889: Diff 27828.Apr 27 2022, 3:21 PM

anlambert requested review of this revision.Apr 27 2022, 3:21 PM

lgtm

I think it was an old usage (when we still wanted to load as in we ingested it in the past)...
It'd be great to deprecate that use and finally drop it if it's actually unused (i think it's not).

ardumont accepted this revision.Apr 27 2022, 4:03 PM

This revision is now accepted and ready to land.Apr 27 2022, 4:03 PM

Closed by commit rDLDSVN1633257f11b5: tasks: Remove unnamed arguments use and restore visit_date parsing (authored by anlambert). · Explain WhyApr 27 2022, 4:16 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVN1633257f11b5: tasks: Remove unnamed arguments use and restore visit_date parsing.