Differential D7627

debian: Fix loading when md5sum is missing in dsc file
ClosedPublic
Actions

Authored by anlambert on Apr 21 2022, 5:39 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBASEc4c0a9b5aaa9: debian: Fix loading when md5sum is missing in dsc file

Summary

Some archive integrity checks were failing after downloads as computed
md5sums was compared against empty ones.

Consequently some versions stored as branches were discarded from the
produced snapshot of a debian package.

Fixes SWH-LOADER-CORE-116.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Branch

debian-no-md5sum-loading-fix

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 28686
Build 44824: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 44823: arc lint + arc unit

Event Timeline

anlambert created this revision.Apr 21 2022, 5:39 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 21 2022, 5:39 PM

Build is green

Patch application report for D7627 (id=27619)

Rebasing onto 7fe2d97bca...

First, rewinding head to replay your work on top of it...
Applying: debian: Fix loading when md5sum is missing in dsc file

Changes applied before test

commit aa94af5db3270c9eec85faa2529e7e07f7db9c8a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Apr 21 17:33:21 2022 +0200

    debian: Fix loading when md5sum is missing in dsc file
    
    Some archive integrity checks were failing after downloads as computed
    md5sums was compared against empty ones.
    
    Consequently some versions stored as branches were discarded from the
    produced snapshot of a debian package.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/725/ for more details.

Harbormaster completed remote builds in B28674: Diff 27619.Apr 21 2022, 5:42 PM

anlambert requested review of this revision.Apr 21 2022, 5:42 PM

ardumont accepted this revision.Apr 21 2022, 7:51 PM

This revision is now accepted and ready to land.Apr 21 2022, 7:51 PM

Rebase

Build is green

Patch application report for D7627 (id=27634)

Rebasing onto 7fe2d97bca...

Current branch diff-target is up to date.

Changes applied before test

commit c4c0a9b5aaa99c4f56737e7fda12906140a0bf37
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Apr 21 17:33:21 2022 +0200

    debian: Fix loading when md5sum is missing in dsc file
    
    Some archive integrity checks were failing after downloads as computed
    md5sums was compared against empty ones.
    
    Consequently some versions stored as branches were discarded from the
    produced snapshot of a debian package.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/726/ for more details.

Harbormaster completed remote builds in B28686: Diff 27634.Apr 22 2022, 10:55 AM

Closed by commit rDLDBASEc4c0a9b5aaa9: debian: Fix loading when md5sum is missing in dsc file (authored by anlambert). · Explain WhyApr 22 2022, 10:55 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDBASEc4c0a9b5aaa9: debian: Fix loading when md5sum is missing in dsc file.