- Pass **kwargs to the base loader, instead of repeating the args
- Remove redundant attribute initialization
Details
Details
- Reviewers
ardumont - Group Reviewers
Reviewers - Commits
- rDLDBASE7fe2d97bca03: package loaders: Simplify initialization
Diff Detail
Diff Detail
- Repository
- rDLDBASE Generic VCS/Package Loader
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 28625 Build 44745: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 44744: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D7622 (id=27598)
Rebasing onto 59814745be...
Current branch diff-target is up to date.
Changes applied before test
commit b5a5b980e0814b1c57c6b52da06791542fea696a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Apr 21 13:02:36 2022 +0200
package loaders: Simplify initialization
1. Pass **kwargs to the base loader, instead of repeating the args
2. Remove redundant attribute initializationSee https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/723/ for more details.
Comment Actions
Build is green
Patch application report for D7622 (id=27599)
Rebasing onto 777a23558d...
Current branch diff-target is up to date.
Changes applied before test
commit 7fe2d97bca03ebc22c0b1363c98ca3f1ac367abe
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Thu Apr 21 13:02:36 2022 +0200
package loaders: Simplify initialization
1. Pass **kwargs to the base loader, instead of repeating the args
2. Remove redundant attribute initializationSee https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/724/ for more details.
Comment Actions
Great, thx.
Unrelated to this diff, I just noticed that the PackageLoader class inherits from the swh.loader.core.loader.BaseLoader.
That's not something i remember knowing ¯\_(ツ)_/¯...