Differential D7622

package loaders: Simplify initialization
ClosedPublic
Actions

Authored by vlorentz on Apr 21 2022, 1:02 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDLDBASE7fe2d97bca03: package loaders: Simplify initialization

Summary

Pass **kwargs to the base loader, instead of repeating the args
Remove redundant attribute initialization

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 21 2022, 1:02 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 21 2022, 1:02 PM

Build is green

Patch application report for D7622 (id=27598)

Rebasing onto 59814745be...

Current branch diff-target is up to date.

Changes applied before test

commit b5a5b980e0814b1c57c6b52da06791542fea696a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 13:02:36 2022 +0200

    package loaders: Simplify initialization
    
    1. Pass **kwargs to the base loader, instead of repeating the args
    2. Remove redundant attribute initialization

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/723/ for more details.

Harbormaster completed remote builds in B28625: Diff 27598.Apr 21 2022, 1:05 PM

vlorentz requested review of this revision.Apr 21 2022, 1:05 PM

rebase

Build is green

Patch application report for D7622 (id=27599)

Rebasing onto 777a23558d...

Current branch diff-target is up to date.

Changes applied before test

commit 7fe2d97bca03ebc22c0b1363c98ca3f1ac367abe
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 13:02:36 2022 +0200

    package loaders: Simplify initialization
    
    1. Pass **kwargs to the base loader, instead of repeating the args
    2. Remove redundant attribute initialization

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/724/ for more details.

Harbormaster completed remote builds in B28654: Diff 27599.Apr 21 2022, 1:58 PM

Great, thx.

Unrelated to this diff, I just noticed that the PackageLoader class inherits from the swh.loader.core.loader.BaseLoader.
That's not something i remember knowing ¯\_(ツ)_/¯...

This revision is now accepted and ready to land.Apr 21 2022, 2:36 PM

Closed by commit rDLDBASE7fe2d97bca03: package loaders: Simplify initialization (authored by vlorentz). · Explain WhyApr 21 2022, 5:18 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDLDBASE7fe2d97bca03: package loaders: Simplify initialization.