Page MenuHomeSoftware Heritage

Replace self.url with self.origin.url in package loaders
ClosedPublic

Authored by vlorentz on Apr 20 2022, 11:05 AM.

Details

Summary

For consistency with VCS loaders.

A future commit will introduce more code shared between package and VCS
loaders, and will need to use this attribute.

Diff Detail

Repository
rDLDBASE Generic VCS/Package Loader
Branch
origin-metadata
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28561
Build 44653: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 44652: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D7599 (id=27533)

Rebasing onto 3202f6171b...

Current branch diff-target is up to date.
Changes applied before test
commit ebca5ce0038cb4eca47d8cfc1eae0a5407e6ee39
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 20 11:02:31 2022 +0200

    Replace self.url with self.origin.url in package loaders
    
    For consistency with VCS loaders.
    
    A future commit will introduce more code shared between package and VCS
    loaders, and will need to use this attribute.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/720/ for more details.

This revision is now accepted and ready to land.Apr 20 2022, 11:40 AM