Differential D7599

Replace self.url with self.origin.url in package loaders
ClosedPublic
Actions

Authored by vlorentz on Apr 20 2022, 11:05 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4186: Allow loaders to fetch extrinsic metadata

Commits

rDLDBASEebca5ce0038c: Replace self.url with self.origin.url in package loaders

Summary

For consistency with VCS loaders.

A future commit will introduce more code shared between package and VCS
loaders, and will need to use this attribute.

Diff Detail

Repository

rDLDBASE Generic VCS/Package Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 20 2022, 11:05 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 20 2022, 11:05 AM

Build is green

Patch application report for D7599 (id=27533)

Rebasing onto 3202f6171b...

Current branch diff-target is up to date.

Changes applied before test

commit ebca5ce0038cb4eca47d8cfc1eae0a5407e6ee39
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Apr 20 11:02:31 2022 +0200

    Replace self.url with self.origin.url in package loaders
    
    For consistency with VCS loaders.
    
    A future commit will introduce more code shared between package and VCS
    loaders, and will need to use this attribute.

See https://jenkins.softwareheritage.org/job/DLDBASE/job/tests-on-diff/720/ for more details.

Harbormaster completed remote builds in B28561: Diff 27533.Apr 20 2022, 11:08 AM

vlorentz requested review of this revision.Apr 20 2022, 11:08 AM