Page MenuHomeSoftware Heritage

origin-search: Show original error message to users
ClosedPublic

Authored by vlorentz on Apr 5 2022, 1:32 PM.

Diff Detail

Repository
rDWAPPS Web applications
Branch
origin-search-error
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28121
Build 44046: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 44045: arc lint + arc unit

Event Timeline

anlambert added inline comments.
cypress/integration/origin-search.spec.js
244

The /api/1/origin/search/<query>/ endpoints expects a GET request and an URL argument so that's why the request is not intercepted, use this instead:

cy.intercept(`${this.Urls.api_1_origin_search('**')}**`,

Build has FAILED

Patch application report for D7504 (id=27219)

Rebasing onto 902039b683...

Current branch diff-target is up to date.
Changes applied before test
commit 57004e7e9ee21c1c620a8a876b1397de31393955
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Apr 5 13:32:28 2022 +0200

    origin-search: Show original error message to users

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1674/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1674/console

Harbormaster returned this revision to the author for changes because remote builds failed.Apr 5 2022, 1:57 PM
Harbormaster failed remote builds in B28121: Diff 27219!

Build is green

Patch application report for D7504 (id=27220)

Rebasing onto 902039b683...

Current branch diff-target is up to date.
Changes applied before test
commit fb6d82dd08745971e8e8467260ac4ef063f68c34
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Apr 5 13:32:28 2022 +0200

    origin-search: Show original error message to users

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1676/ for more details.

This revision is now accepted and ready to land.Apr 5 2022, 2:36 PM
This revision was landed with ongoing or failed builds.Apr 5 2022, 2:54 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D7504 (id=27223)

Rebasing onto fc890a1e2a...

Current branch diff-target is up to date.
Changes applied before test
commit c0509f8235d129fe03929a87c12e269f5575d205
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Apr 5 13:32:28 2022 +0200

    origin-search: Show original error message to users

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1678/ for more details.