Paths

Table of Contentst

Differential D7472

Make db_transaction's client_options configurable at run time
ClosedPublic
Actions

Authored by douardda on Mar 30 2022, 2:36 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDCORE2a2615357b07: Make db_transaction's client_options configurable at run time

Summary

allowing these to be easily set from a config file.

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 28034
Build 43907: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 43906: arc lint + arc unit

Event Timeline

douardda created this revision.Mar 30 2022, 2:36 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 30 2022, 2:36 PM

Build is green

Patch application report for D7472 (id=27109)

Rebasing onto 06ad659636...

Current branch diff-target is up to date.

Changes applied before test

commit 679de53dec4bb457e8b2c60a60ce94f4c6f57415
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Mar 30 14:33:27 2022 +0200

    Make db_transaction's client_options configurable at run time
    
    allowing these to be easily set from a config file.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/380/ for more details.

Harbormaster completed remote builds in B28029: Diff 27109.Mar 30 2022, 2:38 PM

douardda requested review of this revision.Mar 30 2022, 2:38 PM

douardda mentioned this in D7473: Make postgresql's Storage client options configurable from config.Mar 30 2022, 2:50 PM

vlorentz added a subscriber: vlorentz.Mar 30 2022, 3:11 PM

vlorentz added inline comments.

swh/core/db/common.py
38–48	You should use double backticks
swh/core/db/tests/test_db.py
363–411	you can remove the tests below with parameterization like this

douardda added inline comments.Mar 30 2022, 3:31 PM

swh/core/db/common.py
38–48	one day I will think about this beforehand...
swh/core/db/tests/test_db.py
363–411	why not

Merge all 4 added tests in a single paramtrized one

Build is green

Patch application report for D7472 (id=27113)

Rebasing onto 06ad659636...

Current branch diff-target is up to date.

Changes applied before test

commit a2136a2ecdd50e45c6c9ce9cd7582546153df035
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Mar 30 14:33:27 2022 +0200

    Make db_transaction's client_options configurable at run time
    
    allowing these to be easily set from a config file.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/381/ for more details.

Harbormaster completed remote builds in B28033: Diff 27113.Mar 30 2022, 3:57 PM

doubleticks

douardda marked an inline comment as done.Mar 30 2022, 4:16 PM

Build is green

Patch application report for D7472 (id=27114)

Rebasing onto 06ad659636...

Current branch diff-target is up to date.

Changes applied before test

commit 2a2615357b0719a9d000f0ccfde67e1767dc296b
Author: David Douard <david.douard@sdfa3.org>
Date:   Wed Mar 30 14:33:27 2022 +0200

    Make db_transaction's client_options configurable at run time
    
    allowing these to be easily set from a config file.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/382/ for more details.

Harbormaster completed remote builds in B28034: Diff 27114.Mar 30 2022, 4:17 PM

The duplication between db_transaction and db_transaction_generator looks a bit silly, but I'm not sure there's much to do about it, so this lgtm, thanks.

This revision is now accepted and ready to land.Apr 4 2022, 3:35 PM

In D7472#195801, @olasd wrote:

The duplication between db_transaction and db_transaction_generator looks a bit silly, but I'm not sure there's much to do about it, so this lgtm, thanks.

yes I stared at this for some time, then went 'meh'

Closed by commit rDCORE2a2615357b07: Make db_transaction's client_options configurable at run time (authored by douardda). · Explain WhyApr 4 2022, 3:38 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDCORE2a2615357b07: Make db_transaction's client_options configurable at run time.