Differential D7399

Add support for author=None and committer=None
ClosedPublic
Actions

Authored by vlorentz on Mar 21 2022, 3:18 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDSTO6fdaf8a05d69: Remove typing workarounds for Revision.author or Revision.committer being None

Summary

committer=None happens on some malformed commits generated by old dgit version;
and it is possible for author=None to happen for the same reason.

Test Plan

Tests will fail because D7400 is not released yet

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 27737
Build 43416: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 43415: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	7 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_tenacious::test_tenacious_proxy_storage_rate_limit[directory] object_type = 'directory', add_func_name = 'directory_add' objects = [Directory(entries=(), id=hash_to_bytes('4b825dc642cb6eb9a060e54bf8d69288fbee4904'), raw_manifest=None), Directory(ent...est=b'tree 34\x0000644 file1.ext\x00\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11\x11')] bad1 = Directory(entries=(DirectoryEntry(name=b'foo', type='file', target=hash_to_bytes('d81cc0710eb6cf9efd5b920a8453e1e07157...4bf8d69288fbee4904'), perms=0o40000)), id=hash_to_bytes('5256e856a0a0898966d6ba14feb4388b8b82d302'), raw_manifest=None)
	8 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_tenacious::test_tenacious_proxy_storage_rate_limit[release] object_type = 'release', add_func_name = 'release_add' objects = [Release(name=b'v0.0.1', message=b'foo', target=hash_to_bytes('0404040404040404040404040404040404040404'), target_type...g 102\x00object 0404040404040404040404040404040404040404\ntype commit\ntag v0.0.1\ntagger foo 1234567890 +200\n\nfoo')] bad1 = Release(name=b'v0.0.1', message=b'synthetic release', target=hash_to_bytes('01a7114f36fddd5ef2511b2cadda237a68adbb12')...offset_bytes=b'+0042'), metadata=None, id=hash_to_bytes('f7f222093a18ec60d781070abec4a630c850b837'), raw_manifest=None)
	13 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.tests.test_tenacious::test_tenacious_proxy_storage_rate_limit[revision] object_type = 'revision', add_func_name = 'revision_add' objects = [Revision(message=b'hello', author=Person(fullname=b'foo', name=b'foo', email=b''), committer=Person(fullname=b'foo', ...parent 9B918DD063CEC85C2BC63CC7F167E29F5894DCBCnauthor foo 1234567891 +0200\ncommitter foo 1234567891 +0200\n\nhello')] bad1 = Revision(message=b'hello', author=Person(fullname=b'Nicolas Dandrimont <nicolas@example.com> ', name=b'Nicolas Dandrim...ders=((b'gpgsig', b'test123'), (b'mergetag', b'foo\\bar'), (b'mergetag', b'"\xaf\x89\x80\x01\x00')), raw_manifest=None)
	4 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_content
	2 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.storage.fixer::swh.storage.fixer._fix_raw_extrinsic_metadata
		View Full Test Results (3 Failed · 1,178 Passed · 40 Skipped)

Event Timeline

vlorentz created this revision.Mar 21 2022, 3:18 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 21 2022, 3:18 PM

Build has FAILED

Patch application report for D7399 (id=26738)

Rebasing onto 98b41c8549...

Current branch diff-target is up to date.

Changes applied before test

commit 54f426d729bfa41571562da61c45698830553044
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 21 15:18:20 2022 +0100

    Add support for author=None and committer=None
    
    committer=None happens on some malformed commits generated by old dgit
    version; and it is possible for author=None to happen for the same reason.
    
    For now, this is not supported by swh-model, so tests temporarily
    disable attrs checks that swh-model relies on.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1577/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1577/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 21 2022, 3:28 PM

Harbormaster failed remote builds in B27633: Diff 26738!

remove workarounds

vlorentz edited the summary of this revision. (Show Details)Mar 21 2022, 3:47 PM

vlorentz edited the test plan for this revision. (Show Details)

Build has FAILED

Patch application report for D7399 (id=26740)

Rebasing onto 98b41c8549...

Current branch diff-target is up to date.

Changes applied before test

commit aed320efc5bccc963b55357b7d646c13da5e417c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 21 15:46:43 2022 +0100

    Remove typing workarounds for Revision.author or Revision.committer being None
    
    swh-model 6.0.0 adds proper support for them.
    
    + fix issue found by mypy

commit 052efb9701dac27dff1ec8ce11faccc874110064
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 21 15:18:20 2022 +0100

    Add support for author=None and committer=None
    
    committer=None happens on some malformed commits generated by old dgit
    version; and it is possible for author=None to happen for the same reason.
    
    For now, this is not supported by swh-model, so tests temporarily
    disable attrs checks that swh-model relies on.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1578/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1578/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 21 2022, 3:48 PM

Harbormaster failed remote builds in B27635: Diff 26740!

vlorentz requested review of this revision.Mar 21 2022, 5:03 PM

vlorentz edited the test plan for this revision. (Show Details)

vlorentz added a parent revision: D7400: Add support for None as author or committer of a Revision.

So, I assume this will bump the swh.model dependency to 6.0 before it lands?

This revision is now accepted and ready to land.Mar 23 2022, 10:48 AM

ah yes, I forgot

rebase + fix test + bump dep

Build has FAILED

Patch application report for D7399 (id=26816)

Rebasing onto 92c78ab547...

Current branch diff-target is up to date.

Changes applied before test

commit 6fdaf8a05d6955dfd53c76d0ceec9226040d9ca8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 21 15:46:43 2022 +0100

    Remove typing workarounds for Revision.author or Revision.committer being None
    
    swh-model 6.0.0 adds proper support for them.
    
    + fix issue found by mypy

commit 3eff720a0c2cabb756a4635bb107659cae3e903a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 21 15:18:20 2022 +0100

    Add support for author=None and committer=None
    
    committer=None happens on some malformed commits generated by old dgit
    version; and it is possible for author=None to happen for the same reason.
    
    For now, this is not supported by swh-model, so tests temporarily
    disable attrs checks that swh-model relies on.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1579/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1579/console

Harbormaster failed remote builds in B27737: Diff 26816!Mar 23 2022, 11:19 AM

Build has FAILED

Patch application report for D7399 (id=26816)

Rebasing onto 92c78ab547...

Current branch diff-target is up to date.

Changes applied before test

commit 6fdaf8a05d6955dfd53c76d0ceec9226040d9ca8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 21 15:46:43 2022 +0100

    Remove typing workarounds for Revision.author or Revision.committer being None
    
    swh-model 6.0.0 adds proper support for them.
    
    + fix issue found by mypy

commit 3eff720a0c2cabb756a4635bb107659cae3e903a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Mar 21 15:18:20 2022 +0100

    Add support for author=None and committer=None
    
    committer=None happens on some malformed commits generated by old dgit
    version; and it is possible for author=None to happen for the same reason.
    
    For now, this is not supported by swh-model, so tests temporarily
    disable attrs checks that swh-model relies on.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1580/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1580/console

olasd added a child revision: D7417: Fix tenacious storage tests for swh.model 6.Mar 23 2022, 4:35 PM

vlorentz mentioned this in D7417: Fix tenacious storage tests for swh.model 6.Mar 23 2022, 4:38 PM

This revision was landed with ongoing or failed builds.Mar 23 2022, 4:48 PM

Closed by commit rDSTO6fdaf8a05d69: Remove typing workarounds for Revision.author or Revision.committer being None (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTO6fdaf8a05d69: Remove typing workarounds for Revision.author or Revision.committer being None.