Differential D7354

backfill: Make integer_ranges() work on str args + add typing to RANGE_GENERATORS
ClosedPublic
Actions

Authored by vlorentz on Mar 15 2022, 5:17 PM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDSTO8b65e42f5adb: backfill: Make integer_ranges() work on str args + add typing to…

Summary

Without the type annotation, mypy errors with 'Cannot call function of unknown type'
when called from a type-checked function.

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 27455
Build 42962: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 42961: arc lint + arc unit

Event Timeline

vlorentz created this revision.Mar 15 2022, 5:17 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 15 2022, 5:17 PM

vlorentz mentioned this in D7352: backfill: Add typing to RANGE_GENERATORS..Mar 15 2022, 5:18 PM

reduce diff + add comment

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 15 2022, 5:19 PM

Harbormaster failed remote builds in B27455: Diff 26575!

Build was aborted

Patch application report for D7354 (id=26574)

Rebasing onto 77f7e6d10a...

Current branch diff-target is up to date.

Changes applied before test

commit 7c45c715094ecf37fde00795bd1990df5c673441
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 15 16:56:40 2022 +0100

    backfill: Make integer_ranges() work on str args + add typing to RANGE_GENERATORS
    
    Without the type annotation, mypy errors with 'Cannot call function of unknown type'
    when called from a type-checked function.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1573/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1573/console

Harbormaster failed remote builds in B27454: Diff 26574!Mar 15 2022, 5:19 PM

Build was aborted

Patch application report for D7354 (id=26575)

Rebasing onto 77f7e6d10a...

Current branch diff-target is up to date.

Changes applied before test

commit de44c76abb0028adc630b67b2aee026cd5b34fbc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 15 16:56:40 2022 +0100

    backfill: Make integer_ranges() work on str args + add typing to RANGE_GENERATORS
    
    Without the type annotation, mypy errors with 'Cannot call function of unknown type'
    when called from a type-checked function.

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1574/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1574/console

remove incorrect comment

Build is green

Patch application report for D7354 (id=26576)

Rebasing onto 77f7e6d10a...

Current branch diff-target is up to date.

Changes applied before test

commit 8b65e42f5adbeef9fd1ef8e28a908c82ee77204f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 15 16:56:40 2022 +0100

    backfill: Make integer_ranges() work on str args + add typing to RANGE_GENERATORS
    
    Without the type annotation, mypy errors with 'Cannot call function of unknown type'
    when called from a type-checked function.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1575/ for more details.

Harbormaster completed remote builds in B27456: Diff 26576.Mar 15 2022, 5:29 PM

vlorentz requested review of this revision.Mar 15 2022, 5:29 PM