Differential D7352

backfill: Add typing to RANGE_GENERATORS.
AbandonedPublic
Actions

Authored by vlorentz on Mar 15 2022, 4:56 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Summary

Without it, mypy errors with 'Cannot call function of unknown type' when called
from a type-checked function.

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 27452
Build 42956: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 42955: arc lint + arc unit

Event Timeline

vlorentz created this revision.Mar 15 2022, 4:56 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 15 2022, 4:56 PM

Build is green

Patch application report for D7352 (id=26572)

Rebasing onto 77f7e6d10a...

Current branch diff-target is up to date.

Changes applied before test

commit b48366ac865457063baac87c0615c039449b0834
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 15 16:56:40 2022 +0100

    backfill: Add typing to RANGE_GENERATORS.
    
    Without it, mypy errors with 'Cannot call function of unknown type' when called
    from a type-checked function.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1572/ for more details.

Harbormaster completed remote builds in B27452: Diff 26572.Mar 15 2022, 5:06 PM

vlorentz requested review of this revision.Mar 15 2022, 5:06 PM

it's incorrect; replaced by D7354

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

swh/

storage/

backfill.py

8 lines

85%

Diff 26572

View Options

backfill: Add typing to RANGE_GENERATORS.AbandonedPublicActions