Page MenuHomeSoftware Heritage

adm_deposit_reschedule: Fix "can not serialize 'datetime.datetime' object"
ClosedPublic

Authored by vlorentz on Mar 15 2022, 10:04 AM.

Details

Summary

Broken by swh-core 0.12.0 (777ea186fa8d31a972ccc15abb7c42297e0a399f / D4690)

Fixes T4013#80819

Test Plan

Not tested

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27436
Build 42935: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 42934: arc lint + arc unit

Unit TestsFailed

Event Timeline

Build has FAILED

Patch application report for D7345 (id=26555)

Rebasing onto 043b96dad3...

Current branch diff-target is up to date.
Changes applied before test
commit 2f6c6cdb9e4beb6d25455c94320123b5fdbd8e93
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 15 10:03:06 2022 +0100

    adm_deposit_reschedule: Fix "can not serialize 'datetime.datetime' object"
    
    Broken by swh-core 0.12.0 (777ea186fa8d31a972ccc15abb7c42297e0a399f)

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/817/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/817/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 15 2022, 10:10 AM
Harbormaster failed remote builds in B27436: Diff 26555!

Build is green

Patch application report for D7345 (id=26557)

Rebasing onto 043b96dad3...

Current branch diff-target is up to date.
Changes applied before test
commit 5d7f67953406063ab09eeb3c40b44f9ea629aded
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 15 10:03:06 2022 +0100

    adm_deposit_reschedule: Fix "can not serialize 'datetime.datetime' object"
    
    Broken by swh-core 0.12.0 (777ea186fa8d31a972ccc15abb7c42297e0a399f)

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/818/ for more details.

ardumont added a subscriber: ardumont.

ok

but lolwat?!

This revision is now accepted and ready to land.Mar 15 2022, 10:39 AM

And most especially, i forgot, thanks!

msgpack (legitimately) cannot serialize a naive datetime, because it needs to convert to a UNIX timestamp