Differential D7345

adm_deposit_reschedule: Fix "can not serialize 'datetime.datetime' object"
ClosedPublic
Actions

Authored by vlorentz on Mar 15 2022, 10:04 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4013: Re-run deposit loaders tasks with corrupt metadata

Commits

rDDEP5d7f67953406: adm_deposit_reschedule: Fix "can not serialize 'datetime.datetime' object"

Summary

Broken by swh-core 0.12.0 (777ea186fa8d31a972ccc15abb7c42297e0a399f / D4690)

Fixes T4013#80819

Test Plan

Not tested

Diff Detail

Repository

rDDEP Push deposit

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 27436
Build 42935: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 42934: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	919 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.cli.test_admin::test_cli_admin_reschedule_nominal cli_runner = <click.testing.CliRunner object at 0x7f82c397b080> complete_deposit = <Deposit: {'id': 133, 'type': 'code', 'status': 'done', 'reception_date': datetime.datetime(2022, 3, 15, 9, 8, 29, 609... 'external-id-complete', 'origin_url': 'https://hal-test.archives-ouvertes.fr/external-id-complete', 'client': 'test'}> swh_scheduler = <swh.scheduler.backend.SchedulerBackend object at 0x7f82c3fa9eb8>
	814 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_basic_auth::test_service_document_basic
	703 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_checks::test_api_checks_check_metadata_ko[no-author]
	597 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_checks::test_api_checks_check_metadata_ko[no-name-or-title]
	708 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_checks::test_api_checks_check_metadata_ko[wrong-author-namespace]
		View Full Test Results (1 Failed · 310 Passed)

Event Timeline

vlorentz created this revision.Mar 15 2022, 10:04 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 15 2022, 10:04 AM

vlorentz mentioned this in T4013: Re-run deposit loaders tasks with corrupt metadata.Mar 15 2022, 10:04 AM

vlorentz edited the summary of this revision. (Show Details)

Build has FAILED

Patch application report for D7345 (id=26555)

Rebasing onto 043b96dad3...

Current branch diff-target is up to date.

Changes applied before test

commit 2f6c6cdb9e4beb6d25455c94320123b5fdbd8e93
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 15 10:03:06 2022 +0100

    adm_deposit_reschedule: Fix "can not serialize 'datetime.datetime' object"
    
    Broken by swh-core 0.12.0 (777ea186fa8d31a972ccc15abb7c42297e0a399f)

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/817/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/817/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 15 2022, 10:10 AM

Harbormaster failed remote builds in B27436: Diff 26555!

oops

Build is green

Patch application report for D7345 (id=26557)

Rebasing onto 043b96dad3...

Current branch diff-target is up to date.

Changes applied before test

commit 5d7f67953406063ab09eeb3c40b44f9ea629aded
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 15 10:03:06 2022 +0100

    adm_deposit_reschedule: Fix "can not serialize 'datetime.datetime' object"
    
    Broken by swh-core 0.12.0 (777ea186fa8d31a972ccc15abb7c42297e0a399f)

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/818/ for more details.

Harbormaster completed remote builds in B27437: Diff 26557.Mar 15 2022, 10:18 AM

vlorentz requested review of this revision.Mar 15 2022, 10:18 AM