Page MenuHomeSoftware Heritage
Differential D7318

Add more Person fields to the schema
ClosedPublic
Actions

Authored by vlorentz on Mar 8 2022, 5:43 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T3965: deposit: Validate Atom documents are well-formed
Commits
rDDEP136016c2f60f: Add more Person fields to the schema
Summary

Depends on D7317.

Diff Detail

Event Timeline

vlorentz created this revision.Mar 8 2022, 5:43 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 8 2022, 5:43 PM
vlorentz added a child revision: D7319: Add support for YYYY and YYYY-MM as date formats.Mar 8 2022, 5:43 PM
swh-public-ci added a comment.Mar 8 2022, 5:50 PM

Build has FAILED

Patch application report for D7318 (id=26463)

Could not rebase; Attempt merge onto cac1511329...

Merge made by the 'recursive' strategy.
 swh/deposit/api/checks.py            |  40 ++++-
 swh/deposit/tests/api/test_checks.py | 316 ++++++++++++++++++++++++++++++++---
 swh/deposit/xsd/codemeta.xsd         |  33 +++-
 3 files changed, 360 insertions(+), 29 deletions(-)
Changes applied before test
commit b162528dd328c9ed5880e4bf54472dd38c6dfab4
Merge: cac15113 abdae949
Author: Jenkins user <jenkins@localhost>
Date:   Tue Mar 8 16:43:40 2022 +0000

    Merge branch 'diff-target' into HEAD

commit abdae94994885cb0bb6d025b8349b34c8aa56d97
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 15:15:06 2022 +0100

    Add more Person fields to the schema

commit 8fc582894c08fb1cd65c0a0dc6557404fcfa1935
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 12:23:07 2022 +0100

    Add more simpletypes to the schema.

commit 96706f67cf53dbb76bce84232c954b1f322b8ab4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 12:17:55 2022 +0100

    Add <codemeta:affiliation> to the schema.

commit 6e85cb9fdcbe5ee1e19d3cc1bcfd1fa42639b56b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 11:46:56 2022 +0100

    test_checks: Make failure more readable

commit 4d3653e309fe0f8a1b895cbe24389a9239baa3d1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 11:36:23 2022 +0100

    test_checks: Add names to pytest parameters + reorder them + remove duplicate
    
    It makes it easier to identify tests when failing + helps git to
    make readable diffs.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/803/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/803/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 8 2022, 5:50 PM
Harbormaster failed remote builds in B27348: Diff 26463!
vlorentz updated this revision to Diff 26468.Mar 8 2022, 6:04 PM

rebase

swh-public-ci added a comment.Mar 8 2022, 6:11 PM

Build is green

Patch application report for D7318 (id=26468)

Could not rebase; Attempt merge onto cac1511329...

Merge made by the 'recursive' strategy.
 swh/deposit/api/checks.py            |  40 ++++-
 swh/deposit/tests/api/test_checks.py | 316 ++++++++++++++++++++++++++++++++---
 swh/deposit/tests/cli/test_client.py |   4 +-
 swh/deposit/xsd/codemeta.xsd         |  33 +++-
 4 files changed, 362 insertions(+), 31 deletions(-)
Changes applied before test
commit 0ac2d5e1d1c720f20dcdbf66944d0660a4f28e7a
Merge: cac15113 c66b1399
Author: Jenkins user <jenkins@localhost>
Date:   Tue Mar 8 17:05:05 2022 +0000

    Merge branch 'diff-target' into HEAD

commit c66b1399af83a5df6f4595cdb05aeacf09d7aefa
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 15:15:06 2022 +0100

    Add more Person fields to the schema

commit e8dd85b6b6164155882ce49ddc2a3f4b0cff5f08
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 12:23:07 2022 +0100

    Add more simpletypes to the schema.

commit 96706f67cf53dbb76bce84232c954b1f322b8ab4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 12:17:55 2022 +0100

    Add <codemeta:affiliation> to the schema.

commit 6e85cb9fdcbe5ee1e19d3cc1bcfd1fa42639b56b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 11:46:56 2022 +0100

    test_checks: Make failure more readable

commit 4d3653e309fe0f8a1b895cbe24389a9239baa3d1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 11:36:23 2022 +0100

    test_checks: Add names to pytest parameters + reorder them + remove duplicate
    
    It makes it easier to identify tests when failing + helps git to
    make readable diffs.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/807/ for more details.

Harbormaster completed remote builds in B27353: Diff 26468.Mar 8 2022, 6:11 PM
vlorentz requested review of this revision.Mar 8 2022, 6:11 PM
vlorentz updated this revision to Diff 26475.Mar 8 2022, 6:11 PM

rebase

swh-public-ci added a comment.Mar 8 2022, 6:19 PM

Build is green

Patch application report for D7318 (id=26475)

Could not rebase; Attempt merge onto cac1511329...

Updating cac15113..64efae98
Fast-forward
 swh/deposit/api/checks.py            |  40 ++++-
 swh/deposit/tests/api/test_checks.py | 316 ++++++++++++++++++++++++++++++++---
 swh/deposit/tests/cli/test_client.py |   4 +-
 swh/deposit/xsd/codemeta.xsd         |  33 +++-
 4 files changed, 362 insertions(+), 31 deletions(-)
Changes applied before test
commit 64efae98071a0b9c9e01bbbcb18c9e26b8230379
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 15:15:06 2022 +0100

    Add more Person fields to the schema

commit 2ec5a89af955992f5c7dbbd63f3ee63573b47a03
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 12:23:07 2022 +0100

    Add more simpletypes to the schema.

commit 043b96dad34dd7b4a351db8bfcac60e681839b0d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 12:17:55 2022 +0100

    Add <codemeta:affiliation> to the schema.

commit e288319cfe7d048bff09556bb6c5aae75eb3a7b2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 11:46:56 2022 +0100

    test_checks: Make failure more readable

commit fb702b02ad6a7c218350900d4f45a2093cd5e9ad
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 11:36:23 2022 +0100

    test_checks: Add names to pytest parameters + reorder them + remove duplicate
    
    It makes it easier to identify tests when failing + helps git to
    make readable diffs.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/814/ for more details.

Harbormaster completed remote builds in B27360: Diff 26475.Mar 8 2022, 6:19 PM
vlorentz added a task: T3965: deposit: Validate Atom documents are well-formed.Mar 14 2022, 10:33 AM
ardumont accepted this revision.Mar 18 2022, 5:40 PM
This revision is now accepted and ready to land.Mar 18 2022, 5:40 PM
vlorentz updated this revision to Diff 26730.Mar 21 2022, 10:39 AM

rebase

swh-public-ci added a comment.Mar 21 2022, 10:48 AM

Build is green

Patch application report for D7318 (id=26730)

Could not rebase; Attempt merge onto 6f37ab6eb7...

Updating 6f37ab6e..136016c2
Fast-forward
 swh/deposit/api/checks.py            |  40 ++++++-
 swh/deposit/tests/api/test_checks.py | 211 +++++++++++++++++++++++++++++++++++
 swh/deposit/tests/cli/test_client.py |   4 +-
 swh/deposit/xsd/codemeta.xsd         |  28 ++++-
 4 files changed, 275 insertions(+), 8 deletions(-)
Changes applied before test
commit 136016c2f60fb4453525a7d2a457e3e3b8a4f06a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 15:15:06 2022 +0100

    Add more Person fields to the schema

commit 172e8d55f41ae18cff532520abdb701945bde335
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 12:23:07 2022 +0100

    Add more simpletypes to the schema.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/822/ for more details.

Harbormaster completed remote builds in B27625: Diff 26730.Mar 21 2022, 10:48 AM
Closed by commit rDDEP136016c2f60f: Add more Person fields to the schema (authored by vlorentz). · Explain WhyMar 22 2022, 11:14 AM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDDEP136016c2f60f: Add more Person fields to the schema.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
deposit/
tests/
api/
48 lines100%
Loading...
xsd/
9 lines--

Diff 26468

View Options

swh/deposit/tests/api/test_checks.py

Loading...
View Options

swh/deposit/xsd/codemeta.xsd

Loading...
About · Developer information · Legal