Page MenuHomeSoftware Heritage
Differential D7319

Add support for YYYY and YYYY-MM as date formats
ClosedPublic
Actions

Authored by vlorentz on Mar 8 2022, 5:43 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T3965: deposit: Validate Atom documents are well-formed
Commits
rDDEP2c5840c85966: Add support for YYYY and YYYY-MM as date formats
Summary

They are allowed by ISO8601, via schema.org, via codemeta; but not by XML Schema's
date format.

Depends on D7318.

Diff Detail

Repository
rDDEP Push deposit
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Mar 8 2022, 5:43 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 8 2022, 5:43 PM
vlorentz added a child revision: D7320: Allow chardata in <codemeta:affiliation>, to be compatible with existing metadata.Mar 8 2022, 5:43 PM
swh-public-ci added a comment.Mar 8 2022, 5:50 PM

Build has FAILED

Patch application report for D7319 (id=26464)

Could not rebase; Attempt merge onto cac1511329...

Merge made by the 'recursive' strategy.
 swh/deposit/api/checks.py            |  40 +++-
 swh/deposit/tests/api/test_checks.py | 348 ++++++++++++++++++++++++++++++++---
 swh/deposit/xsd/codemeta.xsd         |  45 ++++-
 3 files changed, 403 insertions(+), 30 deletions(-)
Changes applied before test
commit b759909b37e229a53b26d15362d96111dcbbc630
Merge: cac15113 62ea1fe1
Author: Jenkins user <jenkins@localhost>
Date:   Tue Mar 8 16:43:59 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 62ea1fe1b8515b8a9481b023456bec7452c787d8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 8 16:15:06 2022 +0100

    Add support for YYYY and YYYY-MM as date formats
    
    They are allowed by ISO8601, via schema.org, via codemeta; but not by XML Schema's
    date format.

commit abdae94994885cb0bb6d025b8349b34c8aa56d97
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 15:15:06 2022 +0100

    Add more Person fields to the schema

commit 8fc582894c08fb1cd65c0a0dc6557404fcfa1935
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 12:23:07 2022 +0100

    Add more simpletypes to the schema.

commit 96706f67cf53dbb76bce84232c954b1f322b8ab4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 12:17:55 2022 +0100

    Add <codemeta:affiliation> to the schema.

commit 6e85cb9fdcbe5ee1e19d3cc1bcfd1fa42639b56b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 11:46:56 2022 +0100

    test_checks: Make failure more readable

commit 4d3653e309fe0f8a1b895cbe24389a9239baa3d1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 11:36:23 2022 +0100

    test_checks: Add names to pytest parameters + reorder them + remove duplicate
    
    It makes it easier to identify tests when failing + helps git to
    make readable diffs.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/804/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/804/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 8 2022, 5:50 PM
Harbormaster failed remote builds in B27349: Diff 26464!
vlorentz updated this revision to Diff 26469.Mar 8 2022, 6:04 PM

rebase

swh-public-ci added a comment.Mar 8 2022, 6:11 PM

Build is green

Patch application report for D7319 (id=26469)

Could not rebase; Attempt merge onto cac1511329...

Merge made by the 'recursive' strategy.
 swh/deposit/api/checks.py            |  40 +++-
 swh/deposit/tests/api/test_checks.py | 348 ++++++++++++++++++++++++++++++++---
 swh/deposit/tests/cli/test_client.py |   4 +-
 swh/deposit/xsd/codemeta.xsd         |  45 ++++-
 4 files changed, 405 insertions(+), 32 deletions(-)
Changes applied before test
commit 5349f68c1f3bdd21904c2377a206538a0d205ea2
Merge: cac15113 f48b0a53
Author: Jenkins user <jenkins@localhost>
Date:   Tue Mar 8 17:05:09 2022 +0000

    Merge branch 'diff-target' into HEAD

commit f48b0a53c4493e9dfd4e42f3836c4a558ecb62de
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 8 16:15:06 2022 +0100

    Add support for YYYY and YYYY-MM as date formats
    
    They are allowed by ISO8601, via schema.org, via codemeta; but not by XML Schema's
    date format.

commit c66b1399af83a5df6f4595cdb05aeacf09d7aefa
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 15:15:06 2022 +0100

    Add more Person fields to the schema

commit e8dd85b6b6164155882ce49ddc2a3f4b0cff5f08
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 12:23:07 2022 +0100

    Add more simpletypes to the schema.

commit 96706f67cf53dbb76bce84232c954b1f322b8ab4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 12:17:55 2022 +0100

    Add <codemeta:affiliation> to the schema.

commit 6e85cb9fdcbe5ee1e19d3cc1bcfd1fa42639b56b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 11:46:56 2022 +0100

    test_checks: Make failure more readable

commit 4d3653e309fe0f8a1b895cbe24389a9239baa3d1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 11:36:23 2022 +0100

    test_checks: Add names to pytest parameters + reorder them + remove duplicate
    
    It makes it easier to identify tests when failing + helps git to
    make readable diffs.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/808/ for more details.

Harbormaster completed remote builds in B27354: Diff 26469.Mar 8 2022, 6:11 PM
vlorentz requested review of this revision.Mar 8 2022, 6:11 PM
vlorentz updated this revision to Diff 26476.Mar 8 2022, 6:11 PM

rebase

swh-public-ci added a comment.Mar 8 2022, 6:19 PM

Build is green

Patch application report for D7319 (id=26476)

Could not rebase; Attempt merge onto cac1511329...

Updating cac15113..87744c57
Fast-forward
 swh/deposit/api/checks.py            |  40 +++-
 swh/deposit/tests/api/test_checks.py | 348 ++++++++++++++++++++++++++++++++---
 swh/deposit/tests/cli/test_client.py |   4 +-
 swh/deposit/xsd/codemeta.xsd         |  45 ++++-
 4 files changed, 405 insertions(+), 32 deletions(-)
Changes applied before test
commit 87744c57b2d8900e6000e504c567f1a5d22bf31d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 8 16:15:06 2022 +0100

    Add support for YYYY and YYYY-MM as date formats
    
    They are allowed by ISO8601, via schema.org, via codemeta; but not by XML Schema's
    date format.

commit 64efae98071a0b9c9e01bbbcb18c9e26b8230379
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 15:15:06 2022 +0100

    Add more Person fields to the schema

commit 2ec5a89af955992f5c7dbbd63f3ee63573b47a03
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 12:23:07 2022 +0100

    Add more simpletypes to the schema.

commit 043b96dad34dd7b4a351db8bfcac60e681839b0d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 12:17:55 2022 +0100

    Add <codemeta:affiliation> to the schema.

commit e288319cfe7d048bff09556bb6c5aae75eb3a7b2
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 11:46:56 2022 +0100

    test_checks: Make failure more readable

commit fb702b02ad6a7c218350900d4f45a2093cd5e9ad
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 11:36:23 2022 +0100

    test_checks: Add names to pytest parameters + reorder them + remove duplicate
    
    It makes it easier to identify tests when failing + helps git to
    make readable diffs.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/815/ for more details.

Harbormaster completed remote builds in B27361: Diff 26476.Mar 8 2022, 6:19 PM
ardumont accepted this revision.Mar 11 2022, 4:12 PM
This revision is now accepted and ready to land.Mar 11 2022, 4:12 PM
vlorentz added a task: T3965: deposit: Validate Atom documents are well-formed.Mar 14 2022, 10:33 AM
vlorentz updated this revision to Diff 26731.Mar 21 2022, 10:39 AM

rebase

swh-public-ci added a comment.Mar 21 2022, 10:48 AM

Build is green

Patch application report for D7319 (id=26731)

Could not rebase; Attempt merge onto 6f37ab6eb7...

Updating 6f37ab6e..2c5840c8
Fast-forward
 swh/deposit/api/checks.py            |  40 +++++-
 swh/deposit/tests/api/test_checks.py | 243 +++++++++++++++++++++++++++++++++++
 swh/deposit/tests/cli/test_client.py |   4 +-
 swh/deposit/xsd/codemeta.xsd         |  40 +++++-
 4 files changed, 318 insertions(+), 9 deletions(-)
Changes applied before test
commit 2c5840c859667ba673d1f00204b95b0ca6f4db0b
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Mar 8 16:15:06 2022 +0100

    Add support for YYYY and YYYY-MM as date formats
    
    They are allowed by ISO8601, via schema.org, via codemeta; but not by XML Schema's
    date format.

commit 136016c2f60fb4453525a7d2a457e3e3b8a4f06a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 15:15:06 2022 +0100

    Add more Person fields to the schema

commit 172e8d55f41ae18cff532520abdb701945bde335
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 28 12:23:07 2022 +0100

    Add more simpletypes to the schema.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/823/ for more details.

Harbormaster completed remote builds in B27626: Diff 26731.Mar 21 2022, 10:48 AM
Closed by commit rDDEP2c5840c85966: Add support for YYYY and YYYY-MM as date formats (authored by vlorentz). · Explain WhyMar 22 2022, 11:14 AM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDDEP2c5840c85966: Add support for YYYY and YYYY-MM as date formats.

Revision Contents
Changeset List

PathSize
swh/
deposit/
tests/
api/
32 lines
xsd/
12 lines

Diff 26754

View Options

swh/deposit/tests/api/test_checks.py

Loading...
View Options

swh/deposit/xsd/codemeta.xsd

Loading...
About · Developer information · Legal