This will be used by the objstorage (and possibly the storage as well)
to publish metrics to statsd.
Details
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- rDCOREc98925db248d: RPCServerApp: Add hooks to add behaviors to generated methods
Diff Detail
Diff Detail
- Repository
- rDCORE Foundations and core functionalities
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Event Timeline
Comment Actions
Build is green
Patch application report for D7271 (id=26331)
Could not rebase; Attempt merge onto 9c9475f769...
Updating 9c9475f..526dc6c Fast-forward swh/core/api/__init__.py | 56 ++++++++++++++++++++++++---- swh/core/api/tests/test_rpc_client_server.py | 2 +- 2 files changed, 49 insertions(+), 9 deletions(-)
Changes applied before test
commit 526dc6c83c674c40e9ba39e4ea0a8f29e2e68034
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Mar 1 15:52:53 2022 +0100
RPCServerApp: Add hooks to add behaviors to generated methods
This will be used by the objstorage (and possibly the storage as well)
to publish metrics to statsd.
commit a2af8c667e32e0523ae371506abc5aa0d11a85f8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Mar 1 15:04:44 2022 +0100
RPCClient: Make methods {get,post}{,_stream} protected
I want to make swh-objstorage inherit from RPCClient, but its get() and get_stream()
methods would class with RPCClient's.See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/363/ for more details.
Comment Actions
Looks useful, thanks.
| swh/core/api/__init__.py | ||
|---|---|---|
| 455 | "applied to all methods generated from the backend class", rather? | |
| swh/core/api/__init__.py | ||
|---|---|---|
| 455 | *shrug* | |
Comment Actions
Build is green
Patch application report for D7271 (id=26333)
Could not rebase; Attempt merge onto 9c9475f769...
Updating 9c9475f..c98925d Fast-forward swh/core/api/__init__.py | 56 ++++++++++++++++++++++++---- swh/core/api/tests/test_rpc_client_server.py | 2 +- 2 files changed, 49 insertions(+), 9 deletions(-)
Changes applied before test
commit c98925db248d56d74d2b9e10569383ee70812c30
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Mar 1 15:52:53 2022 +0100
RPCServerApp: Add hooks to add behaviors to generated methods
This will be used by the objstorage (and possibly the storage as well)
to publish metrics to statsd.
commit a2af8c667e32e0523ae371506abc5aa0d11a85f8
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Mar 1 15:04:44 2022 +0100
RPCClient: Make methods {get,post}{,_stream} protected
I want to make swh-objstorage inherit from RPCClient, but its get() and get_stream()
methods would class with RPCClient's.See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/364/ for more details.