Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T3894: Add a 'swh db upgrade' cli

Commits

rDSCH5cc62be1a405: Adapt to swh.core 2.0.0

Summary

add the get_datastore function in swh.scheduler
add the get_current_version method in SchedulerBackend,
remove dbversion management from sql init script
update tests accordingly

Depends on D7155
Related to T3894

Diff Detail

Repository

rDSCH Scheduling utilities

Branch

master

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 27123
Build 42419: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 42418: arc lint + arc unit

Event Timeline

douardda created this revision.Feb 11 2022, 5:14 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 11 2022, 5:14 PM

Build has FAILED

Patch application report for D7165 (id=25967)

Rebasing onto 234e165967...

First, rewinding head to replay your work on top of it...
Applying: Adapt to swh.core 2.0.0

Changes applied before test

commit 7688a7f388a3ee935fcefee80aca7f912a0608d2
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:59:29 2022 +0100

    Adapt to swh.core 2.0.0
    
    - add the `get_datastore` function in `swh.scheduler`
    - add the `get_current_version` method in `SchedulerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

Link to build: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/519/
See console output for more information: https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/519/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 11 2022, 5:15 PM

Harbormaster failed remote builds in B26843: Diff 25967!

Build is green

Patch application report for D7165 (id=25967)

Rebasing onto 234e165967...

First, rewinding head to replay your work on top of it...
Applying: Adapt to swh.core 2.0.0

Changes applied before test

commit 794f99dae15e1cf1d4afc1a2c0db118e92775ee9
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:59:29 2022 +0100

    Adapt to swh.core 2.0.0
    
    - add the `get_datastore` function in `swh.scheduler`
    - add the `get_current_version` method in `SchedulerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/520/ for more details.

Harbormaster completed remote builds in B26843: Diff 25967.Feb 23 2022, 11:31 AM

douardda requested review of this revision.Feb 23 2022, 11:31 AM

vlorentz accepted this revision.Feb 23 2022, 11:38 AM

This revision is now accepted and ready to land.Feb 23 2022, 11:38 AM

Bump dep to swh.core 2

Build is green

Patch application report for D7165 (id=26242)

Rebasing onto 234e165967...

Current branch diff-target is up to date.

Changes applied before test

commit c72e1797188abeaad1394492b2e30b63f6223fc7
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:59:29 2022 +0100

    Adapt to swh.core 2.0.0
    
    - add the `get_datastore` function in `swh.scheduler`
    - add the `get_current_version` method in `SchedulerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/521/ for more details.

Harbormaster completed remote builds in B27114: Diff 26242.Feb 24 2022, 11:29 AM

Add types-toml to requirements-test.txt to please mypy

on my machine, 'tox -e mypy' is unhappy without it.

Build is green

Patch application report for D7165 (id=26251)

Rebasing onto 234e165967...

Current branch diff-target is up to date.

Changes applied before test

commit b953975ff69cd28ab85a4295a88948a35185d7f1
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:59:29 2022 +0100

    Adapt to swh.core 2.0.0
    
    - add the `get_datastore` function in `swh.scheduler`
    - add the `get_current_version` method in `SchedulerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

commit aabbee7862abbd62c4a2a64121f1442e66b369c8
Author: David Douard <david.douard@sdfa3.org>
Date:   Thu Feb 24 12:20:50 2022 +0100

    Add types-toml to requirements-test.txt
    
    to please mypy.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/522/ for more details.

Harbormaster completed remote builds in B27123: Diff 26251.Feb 24 2022, 12:26 PM

Remove the rev adding the dep. on types-toml

this should come from swh.core if any (see D7247).

Build is green

Patch application report for D7165 (id=26267)

Rebasing onto 234e165967...

Current branch diff-target is up to date.

Changes applied before test

commit 5cc62be1a4059680b534c810ee97b8b80ac9cd56
Author: David Douard <david.douard@sdfa3.org>
Date:   Tue Feb 8 14:59:29 2022 +0100

    Adapt to swh.core 2.0.0
    
    - add the `get_datastore` function in `swh.scheduler`
    - add the `get_current_version` method in `SchedulerBackend`,
    - remove dbversion management from sql init script
    - update tests accordingly

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/523/ for more details.

Harbormaster completed remote builds in B27138: Diff 26267.Feb 24 2022, 3:57 PM

In D7165#188712, @douardda wrote:

Remove the rev adding the dep. on types-toml

this should come from swh.core if any (see D7247).

this is actually not needed at all it seems...

Closed by commit rDSCH5cc62be1a405: Adapt to swh.core 2.0.0 (authored by douardda). · Explain WhyFeb 24 2022, 4:34 PM

This revision was automatically updated to reflect the committed changes.

douardda added a commit: rDSCH5cc62be1a405: Adapt to swh.core 2.0.0.

Adapt scheduler to swh.core 2.0.0ClosedPublicActions

Details

Diff Detail

Event Timeline

Patch application report for D7165 (id=25967)

Changes applied before test

Patch application report for D7165 (id=25967)

Changes applied before test

Patch application report for D7165 (id=26242)

Changes applied before test

Patch application report for D7165 (id=26251)

Changes applied before test

Patch application report for D7165 (id=26267)

Changes applied before test

Revision ContentsChangeset List

Diff 26251

requirements-swh.txt

requirements-test.txt

sql/updates/02.sql

sql/updates/03.sql

sql/updates/04.sql

sql/updates/05.sql

sql/updates/06.sql

sql/updates/07.sql

sql/updates/08.sql

sql/updates/09.sql

sql/updates/10.sql

sql/updates/11.sql

sql/updates/12.sql

sql/updates/13.sql

sql/updates/14.sql

sql/updates/15.sql

sql/updates/16.sql

sql/updates/17.sql

sql/updates/18.sql

sql/updates/19.sql

sql/updates/20.sql

sql/updates/23.sql

sql/updates/24.sql

sql/updates/25.sql

sql/updates/26.sql

sql/updates/27.sql

sql/updates/28.sql

sql/updates/29.sql

sql/updates/30-bis.sql

sql/updates/30.sql

sql/updates/31.sql

sql/updates/32.sql

sql/updates/33.sql

swh/scheduler/__init__.py

swh/scheduler/backend.py

swh/scheduler/pytest_plugin.py

swh/scheduler/sql/30-schema.sql

swh/scheduler/sql/upgrades/02.sql

swh/scheduler/sql/upgrades/03.sql

swh/scheduler/sql/upgrades/04.sql

swh/scheduler/sql/upgrades/05.sql

swh/scheduler/sql/upgrades/06.sql

swh/scheduler/sql/upgrades/07.sql

swh/scheduler/sql/upgrades/08.sql

swh/scheduler/sql/upgrades/09.sql

swh/scheduler/sql/upgrades/10.sql

swh/scheduler/sql/upgrades/11.sql

swh/scheduler/sql/upgrades/12.sql

swh/scheduler/sql/upgrades/13.sql

swh/scheduler/sql/upgrades/14.sql

swh/scheduler/sql/upgrades/15.sql

swh/scheduler/sql/upgrades/16.sql

swh/scheduler/sql/upgrades/17.sql

swh/scheduler/sql/upgrades/18.sql

swh/scheduler/sql/upgrades/19.sql

swh/scheduler/sql/upgrades/20.sql

swh/scheduler/sql/upgrades/23.sql

swh/scheduler/sql/upgrades/24.sql

swh/scheduler/sql/upgrades/25.sql

swh/scheduler/sql/upgrades/26.sql

swh/scheduler/sql/upgrades/27.sql

swh/scheduler/sql/upgrades/28.sql

swh/scheduler/sql/upgrades/29.sql

swh/scheduler/sql/upgrades/30-bis.sql

Adapt scheduler to swh.core 2.0.0
ClosedPublic
Actions

Revision Contents
Changeset List

swh/scheduler/init.py