Page MenuHomeSoftware Heritage
Differential D820

Fix race condition between swh-storage and swh-storage-db.
ClosedPublic
Actions

Authored by vlorentz on Dec 14 2018, 3:03 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDENVee06ef594bb6: Fix race condition between swh-storage and swh-storage-db.
rCDFDee06ef594bb6: Fix race condition between swh-storage and swh-storage-db.

Diff Detail

Repository
rCDFD Dockerfiles for developers
Branch
pg-race-condition
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 3039
Build 3879: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 14 2018, 3:03 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 14 2018, 3:03 PM
Harbormaster completed remote builds in B3039: Diff 2612.Dec 14 2018, 3:03 PM
ardumont added a subscriber: ardumont.Dec 14 2018, 3:13 PM
ardumont added inline comments.
dockerfiles/swh-storage/entrypoint.sh
31

indexer?

vlorentz updated this revision to Diff 2613.Dec 14 2018, 3:14 PM
  • Fix typo.
Harbormaster completed remote builds in B3040: Diff 2613.Dec 14 2018, 3:14 PM
vlorentz marked 2 inline comments as done.Dec 14 2018, 3:14 PM
vlorentz added inline comments.
dockerfiles/swh-storage/entrypoint.sh
31

Woops :D

vlorentz updated this revision to Diff 2614.Dec 14 2018, 3:17 PM
vlorentz marked an inline comment as done.
  • Actually hide stderr
Harbormaster completed remote builds in B3041: Diff 2614.Dec 14 2018, 3:17 PM
ardumont added a subscriber: douardda.Dec 14 2018, 4:00 PM

@douardda how do we usually deal with kind of issues?

ardumont accepted this revision.Dec 14 2018, 5:46 PM

Apparently some people use stuff like dockerize for that [1]

This sounds like a good and simple first approximation of what the other stuff do so why not ;)

[1] https://www.blog.labouardy.com/preventing-race-conditions-in-docker/

This revision is now accepted and ready to land.Dec 14 2018, 5:46 PM
vlorentz updated this revision to Diff 2639.Dec 17 2018, 11:06 AM
  • rebase/squash
Harbormaster completed remote builds in B3069: Diff 2639.Dec 17 2018, 11:06 AM
Closed by commit rCDFDee06ef594bb6: Fix race condition between swh-storage and swh-storage-db. (authored by vlorentz). · Explain WhyDec 17 2018, 11:06 AM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDENVee06ef594bb6: Fix race condition between swh-storage and swh-storage-db..Nov 26 2019, 1:34 PM

Revision Contents
Changeset List

PathSize
dockerfiles/
swh-storage/
5 lines

Diff 2612

View Options

dockerfiles/swh-storage/entrypoint.sh

Loading...
About · Developer information · Legal