	Time	Test
	27,966 ms	Jenkins > should paginate backward from the last page::Tests / Cypress tests / Run cypress tests / Test origin-search Test pagination should paginate backward from the last page AssertionError: Timed out retrying after 20000ms: expected '<li#origins-next-results-button.page-item>' to have class 'disabled' at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-search.spec.js:372:48)
	44,962 ms	Jenkins > should paginate forward when there are many results::Tests / Cypress tests / Run cypress tests / Test origin-search Test pagination should paginate forward when there are many results AssertionError: Timed out retrying after 20000ms: Not enough elements found. Found '1', expected '100'. at Context.eval (http://localhost:5004/__cypress/tests?p=cypress/integration/origin-search.spec.js:306:44)
	215 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_available_for_staff_user
	218 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_available_for_user_with_permission
	155 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.web.tests.admin.test_deposit::Tests / Python tests / test_deposit_admin_view_not_available_for_anonymous_user
		View Full Test Results (2 Failed · 796 Passed · 5 Skipped)

Event Timeline

vlorentz created this revision.Feb 14 2022, 1:30 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 14 2022, 1:30 PM

Build was aborted

Patch application report for D7169 (id=25980)

Rebasing onto 09b8522455...

Current branch diff-target is up to date.

Changes applied before test

commit 45052d2b966455f2653aa4d76f79add1b542793e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 14 13:30:25 2022 +0100

    api_origin_search: Copy all params to build 'link-next'.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1381/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1381/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 14 2022, 1:52 PM

Harbormaster failed remote builds in B26855: Diff 25980!

Build was aborted

Patch application report for D7169 (id=25980)

Rebasing onto aa948f6831...

First, rewinding head to replay your work on top of it...
Applying: api_origin_search: Copy all params to build 'link-next'.

Changes applied before test

commit be8f940203f926a51deee12c93c9d040a5af1e16
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 14 13:30:25 2022 +0100

    api_origin_search: Copy all params to build 'link-next'.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1385/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1385/console

anlambert added a subscriber: anlambert.Feb 14 2022, 5:22 PM

anlambert added inline comments.

swh/web/api/views/origin.py
210	Why `v[0]` ? If I use this `{k: v for (k, v) in request.query_params.items()}`, the tests are no longer failing.

wat

Build is green

Patch application report for D7169 (id=25995)

Rebasing onto aa948f6831...

Current branch diff-target is up to date.

Changes applied before test

commit d858c9b457d3e66179aabcde92cbbfb5eed87294
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 14 13:30:25 2022 +0100

    api_origin_search: Copy all params to build 'link-next'.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1386/ for more details.

Harbormaster completed remote builds in B26870: Diff 25995.Feb 15 2022, 9:54 AM

vlorentz requested review of this revision.Feb 15 2022, 9:54 AM

anlambert accepted this revision.Feb 15 2022, 11:08 AM

This revision is now accepted and ready to land.Feb 15 2022, 11:08 AM

Closed by commit rDWAPPSd858c9b457d3: api_origin_search: Copy all params to build 'link-next'. (authored by vlorentz). · Explain WhyFeb 16 2022, 9:10 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPSd858c9b457d3: api_origin_search: Copy all params to build 'link-next'..