Page MenuHomeSoftware Heritage

api_origin_search: Copy all params to build 'link-next'.
ClosedPublic

Authored by vlorentz on Feb 14 2022, 1:30 PM.

Diff Detail

Repository
rDWAPPS Web applications
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 26855
Build 41982: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 41981: arc lint + arc unit

Event Timeline

Build was aborted

Patch application report for D7169 (id=25980)

Rebasing onto 09b8522455...

Current branch diff-target is up to date.
Changes applied before test
commit 45052d2b966455f2653aa4d76f79add1b542793e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 14 13:30:25 2022 +0100

    api_origin_search: Copy all params to build 'link-next'.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1381/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1381/console

Harbormaster returned this revision to the author for changes because remote builds failed.Feb 14 2022, 1:52 PM
Harbormaster failed remote builds in B26855: Diff 25980!

Build was aborted

Patch application report for D7169 (id=25980)

Rebasing onto aa948f6831...

First, rewinding head to replay your work on top of it...
Applying: api_origin_search: Copy all params to build 'link-next'.
Changes applied before test
commit be8f940203f926a51deee12c93c9d040a5af1e16
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 14 13:30:25 2022 +0100

    api_origin_search: Copy all params to build 'link-next'.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1385/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1385/console

anlambert added inline comments.
swh/web/api/views/origin.py
210

Why v[0] ? If I use this {k: v for (k, v) in request.query_params.items()}, the tests are no longer failing.

Build is green

Patch application report for D7169 (id=25995)

Rebasing onto aa948f6831...

Current branch diff-target is up to date.
Changes applied before test
commit d858c9b457d3e66179aabcde92cbbfb5eed87294
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Feb 14 13:30:25 2022 +0100

    api_origin_search: Copy all params to build 'link-next'.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1386/ for more details.

This revision is now accepted and ready to land.Feb 15 2022, 11:08 AM